mfd: wm5102: Mark only extant DSP registers volatile
Subsystems (2)
PATCH 1/1 mfd: wm5102: Mark only extant DSP registers volatile
Since regmap sometimes uses volatile as a proxy for readable simply having a blanket condition can mark too many registers as readable.
Signed-off-by Mark Brown <[email protected]>
--- drivers/mfd/wm5102-tables.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/mfd/wm5102-tables.c +7 -4
@@ -1837,9 +1837,6 @@ static bool wm5102_readable_register(struct device *dev, unsigned int reg)static bool wm5102_volatile_register (struct device *dev,unsigned int reg) { -if (reg >0xffff ) -return true; -switch (reg) {case ARIZONA_SOFTWARE_RESET :case ARIZONA_DEVICE_REVISION :
@@ -1884,7 +1881,13 @@ static bool wm5102_volatile_register(struct device *dev, unsigned int reg)case ARIZONA_MIC_DETECT_3 :return true;default : -return false; +if ((reg >=0x100000 && reg <0x106000 ) || + (reg >=0x180000 && reg <0x180800 ) || + (reg >=0x190000 && reg <0x194800 ) || + (reg >=0x1a8000 && reg <0x1a9800 )) +return true; +else +return false; } }
Signature · 1 line
1.7.10.4
Samuel Ortiz
AppliedHi Mark,
Quoted 7 lines · Mark Brown
Since regmap sometimes uses volatile as a proxy for readable simply having a blanket condition can mark too many registers as readable.
Signed-off-by Mark Brown <[email protected]>--- drivers/mfd/wm5102-tables.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
Applied, thanks.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/