Skip to contentSkip to conversation

dw_dmac: remove redundant check

PATCH In review Andy Shevchenko 2 participants 2 messages Dec 14, 2012 dmaengine

lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 dw_dmac: remove redundant check

There is no need to check the callback_required parameter, due to we check the callback pointer to be a non-NULL.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/dma/dw_dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dw_dmac.c +1 -1
index 92f33af..3c8acfa 100644
@@ -364,7 +364,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
 
 	spin_unlock_irqrestore(&dwc->lock, flags);
 
-	if (callback_required && callback)
+	if (callback)
 		callback(param);
 }
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Andy Shevchenko

There is no need to check the callback_required parameter, due to we check the callback pointer to be a non-NULL.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/dma/dw_dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dw_dmac.c +0 -0
index 92f33af..3c8acfa 100644

drivers/dma/dw_dmac.c dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc, · line 369

Quoted 7 lines
drivers/dma/dw_dmac.c +1 -1
@@ -364,7 +364,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
 
        spin_unlock_irqrestore(&dwc->lock, flags);
 
-       if (callback_required && callback)
+       if (callback)
                callback(param);
 }
Acked-by Viresh Kumar <[email protected]>