blackfin: time-ts: Remove duplicate assignment
It seems that this assignment is done twice in a row. Remove the duplicate assignment.
---
Noticed while grepping for broadcast users.
arch/blackfin/kernel/time-ts.c | 6 ------ 1 file changed, 6 deletions(-)
arch/blackfin/kernel/time-ts.c +0 -6
@@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void) evt->broadcast = smp_timer_broadcast;#endif - -#ifdef CONFIG_SMP - evt->broadcast = smp_timer_broadcast; -#endif - - evt->name ="bfin_core_timer" ; evt->rating =350 ; evt->irq =-1 ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Jesper Juhl
Reviewed-byQuoted 21 lines · Stephen Boyd
It seems that this assignment is done twice in a row. Remove the duplicate assignment.
Signed-off-by Stephen Boyd <[email protected]>Cc Steven Miao <[email protected]>---
Noticed while grepping for broadcast users.
arch/blackfin/kernel/time-ts.c | 6 ------ 1 file changed, 6 deletions(-)arch/blackfin/kernel/time-ts.c +0
-0@@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void) evt->broadcast = smp_timer_broadcast;#endif
arch/blackfin/kernel/time-ts.c void bfin_coretmr_clockevent_init(void) · line 334
Quoted 10 lines
arch/blackfin/kernel/time-ts.c +0
-6- -#ifdef CONFIG_SMP - evt->broadcast = smp_timer_broadcast; -#endif - - evt->name ="bfin_core_timer" ; evt->rating =350 ; evt->irq =-1 ;
Looks good to me.
Feel free to add
if you like.
Signature · 3 lines
Jesper Juhl <[email protected]> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
Quoted 3 lines · Stephen Boyd
It seems that this assignment is done twice in a row. Remove the duplicate assignment.
That's right.
Will be applied, thanks.
Quoted 31 lines
Signed-off-by Stephen Boyd <[email protected]>Cc Steven Miao <[email protected]>---
Noticed while grepping for broadcast users.
arch/blackfin/kernel/time-ts.c | 6 ------ 1 file changed, 6 deletions(-)arch/blackfin/kernel/time-ts.c +0
-7@@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void) evt->broadcast = smp_timer_broadcast;#endif - -#ifdef CONFIG_SMP - evt->broadcast = smp_timer_broadcast; -#endif - - evt->name ="bfin_core_timer" ; evt->rating =350 ; evt->irq =-1 ; --The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Signature · 2 lines
Regards, --Bob
A message that is not in the archive (sent off-list or not yet received): CAA_GA1fDv4OP+7sZ-Hxr0Zyb_gGe3Xpn7DvkokMAG2u4AByScQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
yes, duplicated. should be removed.
Quoted 40 lines · Bob Liu
Quoted 3 lines · Stephen Boyd
It seems that this assignment is done twice in a row. Remove the duplicate assignment.
That's right.
Will be applied, thanks.Review
Quoted 11 lines
Signed-off-by Stephen Boyd <[email protected]>Cc Steven Miao <[email protected]>---
Noticed while grepping for broadcast users.
arch/blackfin/kernel/time-ts.c | 6 ------ 1 file changed, 6 deletions(-)(quoted diff) +0
-0
b/arch/blackfin/kernel/time-ts.cQuoted 17 lines
index f608f02..cb0a484 100644
arch/blackfin/kernel/time-ts.c +0
-7@@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void) evt->broadcast = smp_timer_broadcast;#endif - -#ifdef CONFIG_SMP - evt->broadcast = smp_timer_broadcast; -#endif - - evt->name ="bfin_core_timer" ; evt->rating =350 ; evt->irq =-1 ; --Quoted 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
Quoted 7 lines
Quoted 2 lines
hosted by The Linux Foundation
--
Regards,
--Bob
_______________________________________________
Uclinux-dist-devel mailing list Uclinux-dist-devel-ZG0+EudsQA8dtHy/[email protected]
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel