Skip to contentSkip to conversation

mfd, TWL4030: TWL4030 need select REGMAP_I2C

PATCH In review Chuansheng Liu 5 participants 9 messages Dec 24, 2012 – Jan 22, 2013 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd, TWL4030: TWL4030 need select REGMAP_I2C

This patch fix the below build error:
drivers/built-in.o: In function `twl_probe':
drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
make: *** [vmlinux] Error 1

---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mfd/Kconfig +1 -0
index 1c0abd4..47ad4e2 100644
@@ -292,6 +292,7 @@ config TWL4030_CORE
 	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
 	depends on I2C=y && GENERIC_HARDIRQS
 	select IRQ_DOMAIN
+	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
 	  This core driver provides register access and IRQ handling
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Chuansheng Liu

This patch fix the below build error:
drivers/built-in.o: In function `twl_probe':
drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
make: *** [vmlinux] Error 1

Thanks Liu, I have missed this one.

Quoted 19 lines
---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mfd/Kconfig +1 -0
index 1c0abd4..47ad4e2 100644
@@ -292,6 +292,7 @@ config TWL4030_CORE
 	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
 	depends on I2C=y && GENERIC_HARDIRQS
 	select IRQ_DOMAIN
+	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
 	  This core driver provides register access and IRQ handling
#3 lore raw
Quoted 9 lines · Omar Ramirez Luna

Hi,

Quoted 6 lines · Peter Ujfalusi
Quoted 4 lines · Chuansheng Liu

This patch fix the below build error:
drivers/built-in.o: In function `twl_probe':
drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
make: *** [vmlinux] Error 1

Quoted 7 lines
Quoted 3 lines

Thanks Liu, I have missed this one.

Mind taking mine, it was sent before this one :)

https://patchwork.kernel.org/patch/1908991/

Actually it looks like Liu beat me by a few hours, so please ignore mine and the noise.

Cheers,

Omar

#4 lore raw
In reply to Peter Ujfalusi

Hi maintainers,

Could you help to push this patch?
Every time syncing the latest code, always meet this build error. Sorry to disturb.

Quoted 30 lines

-----Original Message-----
From: Peter Ujfalusi [mailto:[email protected]]
Sent: Monday, December 31, 2012 6:04 PM
To: Liu, Chuansheng
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

Quoted 4 lines · Chuansheng Liu

This patch fix the below build error:
drivers/built-in.o: In function `twl_probe':
drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
make: *** [vmlinux] Error 1

Thanks Liu, I have missed this one.

drivers/mfd/Kconfig config TWL4030_CORE · line 292

Quoted 12 lines
---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mfd/Kconfig +0 -0
index 1c0abd4..47ad4e2 100644
@@ -292,6 +292,7 @@ config TWL4030_CORE
 	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0

Support"

Quoted 7 lines

drivers/mfd/Kconfig config TWL4030_CORE · line 298

Quoted 7 lines
drivers/mfd/Kconfig +1 -0
 	depends on I2C=y && GENERIC_HARDIRQS
 	select IRQ_DOMAIN
+	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
 	  This core driver provides register access and IRQ handling

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�

#5 lore raw

Hi Liu,

Quoted 5 lines · Chuansheng

Hi maintainers,

Could you help to push this patch?
Every time syncing the latest code, always meet this build error. Sorry to disturb.

First of all I'm sorry for this, since this is my mistake to not update the Kconfig file at the same time.
AFAIK Samuel is really busy with Intel stuff (might be worth pinging him within Intel), but I'm sure he is going to do everything he can to resolve this. We can ask Greg to take this further as well. Whichever is going to be the faster.

Regards,
Péter

Quoted 38 lines
Quoted 38 lines

-----Original Message-----
From: Peter Ujfalusi [mailto:[email protected]]
Sent: Monday, December 31, 2012 6:04 PM
To: Liu, Chuansheng
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

Quoted 4 lines · Chuansheng Liu

This patch fix the below build error:
drivers/built-in.o: In function `twl_probe':
drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
make: *** [vmlinux] Error 1

Thanks Liu, I have missed this one.

drivers/mfd/Kconfig config TWL4030_CORE · line 292

Quoted 12 lines
---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mfd/Kconfig +0 -0
index 1c0abd4..47ad4e2 100644
@@ -292,6 +292,7 @@ config TWL4030_CORE
 	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0

Support"

Quoted 7 lines
drivers/mfd/Kconfig +1 -0
 	depends on I2C=y && GENERIC_HARDIRQS
 	select IRQ_DOMAIN
+	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
 	  This core driver provides register access and IRQ handling
#6 lore raw
Quoted 9 lines · Peter Ujfalusi

Hi Liu,

Quoted 5 lines · Chuansheng

Hi maintainers,

Could you help to push this patch?
Every time syncing the latest code, always meet this build error. Sorry to disturb.

Quoted 5 lines

First of all I'm sorry for this, since this is my mistake to not update the Kconfig file at the same time.
AFAIK Samuel is really busy with Intel stuff (might be worth pinging him within Intel), but I'm sure he is going to do everything he can to resolve this. We can ask Greg to take this further as well. Whichever is going to be the faster.

Hm, I'm not taking mfd patches lately, but if needed, I can, just let me know.

thanks,

greg k-h

#7 lore raw
In reply to Liu, Chuansheng

Hi Liu,

Quoted 5 lines · Chuansheng

Hi maintainers,

Could you help to push this patch?
Every time syncing the latest code, always meet this build error. Sorry to disturb.

I was going to take this one when I saw Linus already applied it directly. Sorry for the latency.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#8 lore raw

Thanks Samuel and Linus' help.

Quoted 25 lines

-----Original Message-----
From: Samuel Ortiz [mailto:[email protected]]
Sent: Tuesday, January 22, 2013 8:37 AM
To: Liu, Chuansheng
Cc: Peter Ujfalusi; [email protected]; [email protected]; [email protected]; Omar Ramirez Luna
Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

Hi Liu,

Quoted 5 lines · Chuansheng

Hi maintainers,

Could you help to push this patch?
Every time syncing the latest code, always meet this build error. Sorry to disturb.

I was going to take this one when I saw Linus already applied it directly. Sorry for the latency.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/