max is back
Hello all,
If anyone remembers I was working on a usb to can adapter. The Dev-kit I was using was defective and put the project on hiatus. I've got a fresh kit now and the first working firmware version.
I'm using a user-space driver for now, and have the basic workings hashed out as follows. (for reception)
1) open the usb device.
2) send byte order indicator and host frame format to each can interface.
char data[10];uint16_t ekey = 0xbeef;
int len = sprintf(data,"%c%c""%c%c%c%c\n",
((uint8_t *)&ekey)[0],((uint8_t *)&ekey)[1], (char)sizeof(struct can_frame), (char)((size_t)(&((struct can_frame *)0)->can_id)), (char)((size_t)(&((struct can_frame *)0)->can_dlc)), (char)((size_t)(&((struct can_frame *)0)->data))
);
libusb_control_transfer( .... data, ... );
3) send baudrate/mode/other settings to each interface.
3) prepare/submit some usb requests
libusb_fill_bulk_transfer(transfer_object,
usb_device, endpoint,
(unsigned char *)&frame, sizeof(struct can_frame), transfer_callback,
NULL, 1000 );
4) callbacks are really clean and look something like this:
void transfer_callback(struct libusb_transfer *transfer){
struct can_frame *frame = (struct can_frame *)transfer->buffer;
switch(transfer->status){
case LIBUSB_TRANSFER_COMPLETED:;
//pass frame to can system
break;
//handle errors
}
libusb_submit_transfer(transfer);
}I remember in an earlier discussion with Marc and Oliver describing this method. Is this what you had in mind?
I can signal bus errors by creating genuine struct can_frame errors this way as well. How would I signal buffer overrun on the device?
Regarding setting the baudrate. How is this normally done? direct access to the TQs, propseg, phas1/2 seg, etc?
Now I have some questions regarding sending messages. actually I'd just like more help understanding this:
Quoted 1 line
Quoted 1 line
To provide a state-of-the-art echo functionality the sk pointer
(skb->sk) is
Quoted 1 line
Quoted 1 line
sent along with the CAN frame. This allows to
skb_free()the original
tx skb
Quoted 1 line
Quoted 1 line
and create a new one at rx time with the correct sk pointer, when the
frame is
Quoted 1 line
Quoted 1 line
echoed after successful transmission. As we are endian safe the sk
pointer can
Quoted 1 line
Quoted 1 line
be taken from the USB URB as-is. (For security reasons we should
probably not
Quoted 1 line
Quoted 1 line
take the pointer directly but double check with stored echo-skbs)
You are saying that the host sends an extra identifier with the can frame to be sent, and that the firmware sends the entire frame with this identifier back to indicate completion? so I need some message header?
How is time-stamping done with socket-can? struct can_frame (at least on my system) has no 'time_stamp' member. How does an application using socketcan benefit from time-stamping?
Best Regards,
Max S.
Hi Max,
some answers for the points i probably can answer ... :-)
Quoted 2 lines · Max S.
2) send byte order indicator and host frame format to each can interface.
Good idea.
Quoted 9 lines
char data[10];
uint16_tekey =0xbeef;
int len = sprintf(data,"%c%c""%c%c%c%c\n",((uint8_t *)&ekey)[0],((uint8_t *)&ekey)[1], (char)sizeof(struct can_frame), (char)((size_t)(&((struct can_frame *)0)->can_id)), (char)((size_t)(&((struct can_frame *)0)->can_dlc)), (char)((size_t)(&((struct can_frame *)0)->data))
Quoted 5 lines
);
libusb_control_transfer( .... data, ... );
3) send baudrate/mode/other settings to each interface.
dito
Quoted 21 lines
3) prepare/submit some usb requests
libusb_fill_bulk_transfer(transfer_object,
usb_device, endpoint,
(unsigned char *)&frame,sizeof(struct can_frame),transfer_callback,
NULL, 1000 );4) callbacks are really clean and look something like this:
void transfer_callback(struct libusb_transfer *transfer){ struct can_frame *frame = (struct can_frame *)transfer->buffer; switch(transfer->status){ case LIBUSB_TRANSFER_COMPLETED:; //pass frame to can system break; //handle errors } libusb_submit_transfer(transfer); }
Quoted 2 lines
I remember in an earlier discussion with Marc and Oliver describing this method. Is this what you had in mind?
Don't know.
Quoted 3 lines
I can signal bus errors by creating genuine struct
can_frameerrors this way as well. How would I signal buffer overrun on the device?
See CAN_ERR_CRTL and CAN_ERR_CRTL_RX_OVERFLOW in include/linux/can/error.h
Quoted 3 lines
Regarding setting the baudrate. How is this normally done? direct access to the TQs, propseg, phas1/2 seg, etc?
See:
http://lxr.linux.no/#linux+v3.7.1/Documentation/networking/can.txt#L766
You can specify a EITHER a bitrate OR the propseg1/2 stuff.
When using the bitrate the internal bitrate calculation is used to determine propseg1/2 and friends. Otherwise the propseg1/2 stuff can be set manually.
To calculate the bitrate the struct can_bittiming_const is needed.
http://lxr.linux.no/#linux+v3.7.1/drivers/net/can/usb/ems_usb.c#L891
Each CAN driver / CAN controller has usually it's own function to put the bittiming into the controllers registers, e.g.:
http://lxr.linux.no/#linux+v3.7.1/drivers/net/can/usb/ems_usb.c#L926
and
http://lxr.linux.no/#linux+v3.7.1/drivers/net/can/sja1000/sja1000.c#L209
Quoted 11 lines
Now I have some questions regarding sending messages. actually I'd just like more help understanding this:
Quoted 1 line
Quoted 1 line
To provide a state-of-the-art echo functionality the sk pointer
(
skb->sk) isQuoted 1 line
Quoted 1 line
sent along with the CAN frame. This allows to
skb_free()the originaltx skb
Quoted 1 line
Quoted 1 line
and create a new one at rx time with the correct sk pointer, when the
frame is
Quoted 1 line
Quoted 1 line
echoed after successful transmission. As we are endian safe the sk
Quoted 8 lines
pointer can
Quoted 1 line
Quoted 1 line
be taken from the USB URB as-is. (For security reasons we should
probably not
Quoted 1 line
Quoted 1 line
take the pointer directly but double check with stored echo-skbs)
You are saying that the host sends an extra identifier with the can frame to be sent, and that the firmware sends the entire frame with this identifier back to indicate completion?
Yes.
Quoted 1 line
so I need some message header?
You need to put the CAN frame into the URB in some way anyway. Is there any problem to add this additional unique identifier along with the CAN frame?
E.g. a zero identifier in the rx-path could indicate a 'freshly received' CAN frame, which was not sent by the local host.
Quoted 3 lines
How is time-stamping done with socket-can? struct
can_frame(at least on my system) has no 'time_stamp' member.
The struct can_frame contains the CAN frame - oh, surprise! :-))
The timestamp is part ot the socket buffer (struct skbuff) where the CAN frame is embedded inside the Linux kernel.
The timestamp can be retrieved by standard socket operations:
E.g. as cmsg element within a recvmsg() syscall
https://gitorious.org/linux-can/can-utils/blobs/master/candump.c#line605
or with an ioctl() after read()/recv()
https://gitorious.org/linux-can/can-utils/blobs/master/isotpdump.c#line198
Regards,
Oliver
struct can_bittiming/struct can_berr_counter
Hello,
What is the reason why struct can_bittiming and struct can_berr_counter use __u32 for all its members?
In the case of txerr and rxerr are those not even limited to 255 in the CAN specification?
Max S.
Re: struct can_bittiming/struct can_berr_counter
Quoted 4 lines · Max S.
Hello,
What is the reason why struct
can_bittimingand structcan_berr_counteruse__u32for all its members?
I think mainly for user/kernel space alignment and simplicity reasons. It has been discussed in an early phase of the project, IIRC.
Quoted 2 lines
In the case of txerr and rxerr are those not even limited to 255 in the CAN specification?
I don't have a specication at hand but I have in mind:
0 < error-counter <= 127: error-active state 128 < error-counter <= 255: error-passive state 256 <= error-counter : bus-off
Wolfgang,
Re: struct can_bittiming/struct can_berr_counter
Quoted 9 lines · Wolfgang Grandegger
Quoted 4 lines · Max S.
Hello,
What is the reason why struct
can_bittimingand structcan_berr_counteruse__u32for all its members?I think mainly for user/kernel space alignment and simplicity reasons. It has been discussed in an early phase of the project, IIRC.
Quoted 8 lines
Quoted 2 lines
In the case of txerr and rxerr are those not even limited to 255 in the CAN specification?
I don't have a specication at hand but I have in mind:
0 < error-counter <= 127: error-active state 128 < error-counter <= 255: error-passive state 256 <= error-counter : bus-off
Should be:
0 <= error-counter <= 127: error-active state 128 <= error-counter <= 255: error-passive state 256 <= error-counter : bus-off
Wolfgang,