kgdb,kdb: Setup basic kdb state before invoking commands via kgdb
PATCH 1/1 kgdb,kdb: Setup basic kdb state before invoking commands via kgdb
Although invasive kdb commands are not supported via kgdb, some useful non-invasive commands like bt* require basic kdb state to be setup before calling into the kdb code. Factor out some of this code and call it before and after executing kdb commands via kgdb.
Signed-off-by Matt Klein <[email protected]>
--- kernel/debug/debug_core.h | 2 ++ kernel/debug/gdbstub.c | 7 +++++++ kernel/debug/kdb/kdb_debugger.c | 24 ++++++++++++++++++------ 3 files changed, 27 insertions(+), 6 deletions(-)
kernel/debug/debug_core.h +2 -0
@@ -72,6 +72,8 @@ extern int dbg_kdb_mode;#ifdef CONFIG_KGDB_KDB extern int kdb_stub (struct kgdb_state *ks);extern int kdb_parse (const char *cmdstr); +extern int kdb_common_init_state (struct kgdb_state *ks); +extern int kdb_common_deinit_state (void );#else /* ! CONFIG_KGDB_KDB */ static inline int kdb_stub (struct kgdb_state *ks) {
kernel/debug/gdbstub.c +7 -0
@@ -782,7 +782,14 @@ static void gdb_cmd_query(struct kgdb_state *ks) len = len /2 ; remcom_out_buffer[len++] =0 ; +/* +* Although invasive kdb commands are not supported via kgdb, +* some non-invasive commands need basic setup (e.g., bt*), +* so do that before calling into the kdb code. */ +kdb_common_init_state (ks);kdb_parse (remcom_out_buffer); +kdb_common_deinit_state (); +strcpy (remcom_out_buffer,"OK" ); }break ;
kernel/debug/kdb/kdb_debugger.c +18 -6
@@ -34,6 +34,22 @@ EXPORT_SYMBOL_GPL(kdb_poll_idx);static struct kgdb_state *kdb_ks; +int kdb_common_init_state (struct kgdb_state *ks) +{ + kdb_initial_cpu =atomic_read (&kgdb_active); + kdb_current_task = kgdb_info[ks->cpu].task; + kdb_current_regs = kgdb_info[ks->cpu].debuggerinfo; +return 0 ; +} + +int kdb_common_deinit_state () +{ + kdb_initial_cpu =-1 ; + kdb_current_task =NULL ; + kdb_current_regs =NULL ; +return 0 ; +} +int kdb_stub (struct kgdb_state *ks) {int error =0 ;
@@ -94,9 +110,7 @@ int kdb_stub(struct kgdb_state *ks) }/* Set initial kdb state variables */ KDB_STATE_CLEAR (KGDB_TRANS ); - kdb_initial_cpu =atomic_read (&kgdb_active); - kdb_current_task = kgdb_info[ks->cpu].task; - kdb_current_regs = kgdb_info[ks->cpu].debuggerinfo; +kdb_common_init_state (ks);/* Remove any breakpoints as needed by kdb and clear single step */ kdb_bp_remove ();KDB_STATE_CLEAR (DOING_SS );
@@ -125,9 +139,7 @@ int kdb_stub(struct kgdb_state *ks)* Upon exit from the kdb main loop setup break points and restart * the system based on the requested continue state */ - kdb_initial_cpu =-1 ; - kdb_current_task =NULL ; - kdb_current_regs =NULL ; +kdb_common_deinit_state ();KDB_STATE_CLEAR (PAGER );kdbnearsym_cleanup ();if (error ==KDB_CMD_KGDB ) {
Signature · 1 line
1.8.1