Skip to contentSkip to conversation

mfd: vexpress: export global functions to fix build error

PATCH Applied Guenter Roeck 3 participants 5 messages Jan 6, 2013 – Jan 22, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: vexpress: export global functions to fix build error

Compiling vexpress client drivers as module results in error messages such as

ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!

This is because the global functions in drivers/mfd/vexpress-config.c are not exported. Fix it.

---
 drivers/mfd/vexpress-config.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/mfd/vexpress-config.c +6 -2
index fae15d8..82fed98 100644
@@ -67,6 +67,7 @@ struct vexpress_config_bridge *vexpress_config_bridge_register(
 
 	return bridge;
 }
+EXPORT_SYMBOL(vexpress_config_bridge_register);
 
 void vexpress_config_bridge_unregister(struct vexpress_config_bridge *bridge)
 {
@@ -83,6 +84,7 @@ void vexpress_config_bridge_unregister(struct vexpress_config_bridge *bridge)
 	while (!list_empty(&__bridge.transactions))
 		cpu_relax();
 }
+EXPOPORT_SYMBOL(vexpress_config_bridge_unregister);
 
 
 struct vexpress_config_func {
@@ -142,6 +144,7 @@ struct vexpress_config_func *__vexpress_config_func_get(struct device *dev,
 
 	return func;
 }
+EXPORT_SYMBOL(__vexpress_config_func_get);
 
 void vexpress_config_func_put(struct vexpress_config_func *func)
 {
@@ -149,7 +152,7 @@ void vexpress_config_func_put(struct vexpress_config_func *func)
 	of_node_put(func->bridge->node);
 	kfree(func);
 }
-
+EXPORT_SYMBOL(vexpress_config_func_put);
 
 struct vexpress_config_trans {
 	struct vexpress_config_func *func;
@@ -229,6 +232,7 @@ void vexpress_config_complete(struct vexpress_config_bridge *bridge,
 
 	complete(&trans->completion);
 }
+EXPORT_SYMBOL(vexpress_config_complete);
 
 int vexpress_config_wait(struct vexpress_config_trans *trans)
 {
@@ -236,7 +240,7 @@ int vexpress_config_wait(struct vexpress_config_trans *trans)
 
 	return trans->status;
 }
-
+EXPORT_SYMBOL(vexpress_config_wait);
 
 int vexpress_config_read(struct vexpress_config_func *func, int offset,
 		u32 *data)
Signature · 1 line
1.7.9.7
#1 lore raw
Quoted 9 lines · Guenter Roeck

Compiling vexpress client drivers as module results in error messages such as

ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!

This is because the global functions in drivers/mfd/vexpress-config.c are not exported. Fix it.

Uh, right. Exported read/write but those are pretty much useless without the other ones...

Thanks a lot, I'll get it queued with the other vexpress fixes and push it upstream as soon as possible!

Pawel

Applied
#2 lore raw
In reply to Guenter Roeck

Hi Guenter,

Quoted 5 lines · Guenter Roeck

Compiling vexpress client drivers as module results in error messages such as

ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!

Quoted 7 lines

This is because the global functions in drivers/mfd/vexpress-config.c are not exported. Fix it.

---
 drivers/mfd/vexpress-config.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks for the fix.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#3 lore raw
Quoted 8 lines · Samuel Ortiz

Hi Guenter,

Quoted 5 lines · Guenter Roeck

Compiling vexpress client drivers as module results in error messages such as

ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!

Quoted 9 lines
Quoted 7 lines

This is because the global functions in drivers/mfd/vexpress-config.c are not exported. Fix it.

---
 drivers/mfd/vexpress-config.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks for the fix.

Caution: Looks like I misspelled EXPORT_SYMBOL.

Guenter

#4 lore raw

Hi Guenter,

Quoted 12 lines · Guenter Roeck
Quoted 11 lines · Samuel Ortiz

Hi Guenter,

Quoted 8 lines · Guenter Roeck

Compiling vexpress client drivers as module results in error messages such as

ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!

This is because the global functions in drivers/mfd/vexpress-config.c are not exported. Fix it.

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines
---
 drivers/mfd/vexpress-config.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks for the fix.

Caution: Looks like I misspelled EXPORT_SYMBOL.

I fixed that now.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/