pps: hide more configuration symbols behind CONFIG_PPS
PATCH 1/1 pps: hide more configuration symbols behind CONFIG_PPS
This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if CONFIG_PPS is not selected, such that we are not prompted for these configuration options if CONFIG_PPS is not set.
--- drivers/pps/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)
drivers/pps/Kconfig +4 -0
@@ -21,6 +21,8 @@ config PPS To compile this driver as a module, choose M here: the module will be called pps_core.ko. +if PPS + config PPS_DEBUG bool "PPS debugging messages" depends on PPS
@@ -38,6 +40,8 @@ config NTP_PPS It doesn't work on tickless systems at the moment. +endif + source drivers/pps/clients/Kconfig source drivers/pps/generators/Kconfig
Signature · 1 line
1.7.10.4
Quoted 14 lines · Florian Fainelli
This patch makes
CONFIG_PPS_DEBUGandCONFIG_NTP_PPSbe hidden ifCONFIG_PPSis not selected, such that we are not prompted for these configuration options ifCONFIG_PPSis not set.Signed-off-by Florian Fainelli <[email protected]>--- drivers/pps/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)drivers/pps/Kconfig +0
-0
drivers/pps/Kconfig config PPS · line 25
Quoted 5 lines
drivers/pps/Kconfig +2
-0@@ -21,6 +21,8 @@ config PPS To compile this driver as a module, choose M here: the module will be called pps_core.ko. +if PPS +
If you add this "if" ...
drivers/pps/Kconfig config PPS · line 28
Quoted 3 lines
drivers/pps/Kconfig +0
-0config PPS_DEBUG bool "PPS debugging messages" depends on PPS
... then you should delete this redundant "depends".
Thanks,
Richard
PATCH v2 1/1 pps: hide more configuration symbols behind CONFIG_PPS
This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if CONFIG_PPS is not selected, such that we are not prompted for these configuration options if CONFIG_PPS is not set.
---
Changes since v1:
- dropped the depends on PPS which is now useless
drivers/pps/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/pps/Kconfig +4 -2
@@ -20,10 +20,10 @@ config PPS To compile this driver as a module, choose M here: the module will be called pps_core.ko. +if PPS config PPS_DEBUG bool "PPS debugging messages" - depends on PPS help Say Y here if you want the PPS support to produce a bunch of debug messages to the system log. Select this if you are having a
@@ -31,13 +31,15 @@ config PPS_DEBUG config NTP_PPS bool "PPS kernel consumer support" - depends on PPS && !NO_HZ + depends on !NO_HZ help This option adds support for direct in-kernel time synchronization using an external PPS signal. It doesn't work on tickless systems at the moment. +endif + source drivers/pps/clients/Kconfig source drivers/pps/generators/Kconfig
Signature · 1 line
1.7.10.4
Quoted 3 lines · Florian Fainelli
This patch makes
CONFIG_PPS_DEBUGandCONFIG_NTP_PPSbe hidden ifCONFIG_PPSis not selected, such that we are not prompted for these configuration options ifCONFIG_PPSis not set.
It seems like this patch has not been merged, yet it is still applicable as of 3.9-rc. Andrew can you take it maybe? Thanks!
Quoted 43 lines
Signed-off-by Florian Fainelli <[email protected]>---
Changes since v1:
- dropped the depends on PPS which is now uselessdrivers/pps/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/pps/Kconfig +4
-2@@ -20,10 +20,10 @@ config PPS To compile this driver as a module, choose M here: the module will be called pps_core.ko. +if PPS config PPS_DEBUG bool "PPS debugging messages" - depends on PPS help Say Y here if you want the PPS support to produce a bunch of debug messages to the system log. Select this if you are having a@@ -31,13 +31,15 @@ config PPS_DEBUG config NTP_PPS bool "PPS kernel consumer support" - depends on PPS && !NO_HZ + depends on !NO_HZ help This option adds support for direct in-kernel time synchronization using an external PPS signal. It doesn't work on tickless systems at the moment. +endif + source drivers/pps/clients/Kconfig source drivers/pps/generators/Kconfig