Skip to contentSkip to conversation

mmc: sdhci-esdhc-imx: Remove unused variables

PATCH Superseded Fabio Estevam 2 participants 3 messages Jan 17, 2013

Subsystems (4)
Arm i.MX and Layerscape MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Secure digital host controller interface (SDHCI) NXP i.MX driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 mmc: sdhci-esdhc-imx: Remove unused variables

From: Fabio Estevam <[email protected]>

commit 842afc02cf (mmc: sdhci-esdhc-imx: do not reference platform data after probe) introduced the following build warnings:

drivers/mmc/host/sdhci-esdhc-imx.c:149:30: warning: unused variable 'boarddata' [-Wunused-variable] drivers/mmc/host/sdhci-esdhc-imx.c:181:30: warning: unused variable 'boarddata' [-Wunused-variable]

Remove the unused variables.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/mmc/host/sdhci-esdhc-imx.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +0 -5
index ae68bc9..509be3a 100644
@@ -144,10 +144,6 @@ static inline void esdhc_clrset_le(struct sdhci_host *host, u32 mask, u32 val, i
 
 static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
 {
-	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
-	struct pltfm_imx_data *imx_data = pltfm_host->priv;
-	struct esdhc_platform_data *boarddata = &imx_data->boarddata;
-
 	u32 val = readl(host->ioaddr + reg);
 
 	if (unlikely(reg == SDHCI_CAPABILITIES)) {

@@ -178,7 +174,6 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
 {
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
 	struct pltfm_imx_data *imx_data = pltfm_host->priv;
-	struct esdhc_platform_data *boarddata = &imx_data->boarddata;
 	u32 data;
 
 	if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) {
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

commit 842afc02cf (mmc: sdhci-esdhc-imx: do not reference platform data after probe) introduced the following build warnings:

My bad. The warnings are introduced by my commit 78b2b04 (mmc:
sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from IO accessory).

So with the commit log corrected,

Acked-by Shawn Guo <[email protected]>
Quoted 6 lines

drivers/mmc/host/sdhci-esdhc-imx.c:149:30: warning: unused variable 'boarddata' [-Wunused-variable] drivers/mmc/host/sdhci-esdhc-imx.c:181:30: warning: unused variable 'boarddata' [-Wunused-variable]

Remove the unused variables.

Signed-off-by Fabio Estevam <[email protected]>
author reviewer
#2 lore raw
Quoted 7 lines · Shawn Guo
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

commit 842afc02cf (mmc: sdhci-esdhc-imx: do not reference platform data after probe) introduced the following build warnings:

My bad. The warnings are introduced by my commit 78b2b04 (mmc:

I guess you meant 3f175a6e5 instead. Will fix it in v2.