Skip to contentSkip to conversation

usbnet: introduce flag FLAG_NOARP for usb net devices

PATCH In review Wei Shuai 2 participants 2 messages Jan 20, 2013

Subsystems (5)
Networking Network drivers USB USB networking drivers +1 more subsystems
lore
Share & tools
lore

Wei Shuai

author
#0 lore raw

PATCH 1/2 usbnet: introduce flag FLAG_NOARP for usb net devices

we do have some USB net devices, which cannot do ARP. so we can introduce a new flag FLAG_NOARP, then client drivers can easily handle these kind of devices

Signed-off-by Wei Shuai <[email protected]>
---
 drivers/net/usb/usbnet.c   |    4 ++++
 include/linux/usb/usbnet.h |    1 +
 2 files changed, 5 insertions(+), 0 deletions(-)
drivers/net/usb/usbnet.c +4 -0
index 3d4bf01..f34b2eb 100644
@@ -1448,6 +1448,10 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 		if ((dev->driver_info->flags & FLAG_WWAN) != 0)
 			strcpy(net->name, "wwan%d");
 
+		/* devices that cannot do ARP */
+		if ((dev->driver_info->flags & FLAG_NOARP) != 0)
+			net->flags |= IFF_NOARP;
+
 		/* maybe the remote can't receive an Ethernet MTU */
 		if (net->mtu > (dev->hard_mtu - net->hard_header_len))
 			net->mtu = dev->hard_mtu - net->hard_header_len;
include/linux/usb/usbnet.h +1 -0
index bd45eb7..5de7a22 100644
@@ -100,6 +100,7 @@ struct driver_info {
 #define FLAG_LINK_INTR	0x0800		/* updates link (carrier) status */
 
 #define FLAG_POINTTOPOINT 0x1000	/* possibly use "usb%d" names */
+#define FLAG_NOARP	0x2000		/* device can't do ARP */
 
 /*
  * Indicates to usbnet, that USB driver accumulates multiple IP packets.
Signature · 1 line
1.7.6.5
maintainer
#1 lore raw

When any patch is discarded, the whole series is tossed.

Therefore you must resubmit the entire series, not just one part of it.