fs: Fix a typo in aio_rw_vect_retry()
PATCH 1/1 fs: Fix a typo in aio_rw_vect_retry()
Dave confirmed Jeff's suspicion in [1]:
Quoted 7 lines
Quoted 2 lines
That wants to be
rw_op=do_aio_writein the else clause. How did you test this patch set?Yep, that's certainly a bug. I concentrated on testing on loop mounts, running some fio and ltp testcases, but I'm at a loss to explain how things seem to work as well as they do. Let's see how where fixing this leads.
This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter rather than aio_read and aio_write") from Dave Kleikamp's GIT tree in [2].
[1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
[2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04
--- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/aio.c +1 -1
@@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb) rw_op = do_aio_read; opcode =IOCB_CMD_PREADV ; }else { - rw_op = do_aio_read; + rw_op = do_aio_write; opcode =IOCB_CMD_PWRITEV ; }
Signature · 1 line
1.8.1.1
Quoted 31 lines · Sedat Dilek
Dave confirmed Jeff's suspicion in [1]:
Quoted 7 lines
Quoted 2 lines
That wants to be
rw_op=do_aio_writein the else clause. How did you test this patch set?Yep, that's certainly a bug. I concentrated on testing on loop mounts, running some fio and ltp testcases, but I'm at a loss to explain how things seem to work as well as they do. Let's see how where fixing this leads.
This is a fixup to commit
daf0f6142dd5("fs: useread_iterandwrite_iterrather thanaio_readandaio_write") from Dave Kleikamp's GIT tree in [2].[1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
[2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04Cc Dave Kleikamp <[email protected]>Cc Jeff Moyer <[email protected]>Cc Alexander Viro <[email protected]>[ v2: Misspelled Dave's last name and fix quoting. ]Signed-off-by Sedat Dilek <[email protected]>--- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/aio.c +0
-0
fs/aio.c static ssize_t aio_rw_vect_retry(struct kiocb *iocb) · line 1326
Quoted 8 lines
fs/aio.c +1
-1@@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb) rw_op = do_aio_read; opcode =IOCB_CMD_PREADV ; }else { - rw_op = do_aio_read; + rw_op = do_aio_write; opcode =IOCB_CMD_PWRITEV ; }
Looks Good,
Quoted 7 lines
Signature · 6 lines
1.8.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Carlos