Skip to contentSkip to conversation

lib: devres: Fix build breakage

PATCH In review Thierry Reding 2 participants 2 messages Jan 22, 2013 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: devres: Fix build breakage

The ERR_PTR() and IS_ERR() macros used by the devm_ioremap_resource() function are defined in the linux/err.h header. On ARM this seems to be pulled in by one of the other headers but the build fails at least on OpenRISC.

---
 lib/devres.c | 1 +
 1 file changed, 1 insertion(+)
lib/devres.c +1 -0
index 9c76b3a..88ad759 100644
@@ -1,3 +1,4 @@
+#include <linux/err.h>
 #include <linux/pci.h>
 #include <linux/io.h>
 #include <linux/gfp.h>
Signature · 1 line
1.8.1.1
#1 lore raw
Quoted 6 lines · Thierry Reding

The ERR_PTR() and IS_ERR() macros used by the devm_ioremap_resource() function are defined in the linux/err.h header. On ARM this seems to be pulled in by one of the other headers but the build fails at least on OpenRISC.

You forgot to put a "reported-by:" field in here, which I've now done for you. Please be more considerate in the future.

thanks,

greg k-h