Skip to contentSkip to conversation

radeon_display: Use pointer return error codes

PATCH In review Su, Xuemin 2 participants 2 messages Jan 23, 2013

Subsystems (2)
lore
Share & tools
lore

Su, Xuemin

author
#0 lore raw

PATCH 1/1 radeon_display: Use pointer return error codes

From: xueminsu <[email protected]>
Date: Tue, 22 Jan 2013 22:16:53 +0800
Subject: [PATCH] radeon_display: Use pointer return error codes

drm_mode_addfb() expects fb_create return error code instead of NULL.

---
 drivers/gpu/drm/radeon/radeon_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +1 -1
index 1da2386..ff3def7 100644
@@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
 	if (ret) {
 		kfree(radeon_fb);
 		drm_gem_object_unreference_unlocked(obj);
-		return NULL;
+		return ERR_PTR(ret);
 	}
 
 	return &radeon_fb->base;
Signature · 1 line
1.7.6
#1 lore raw
Quoted 8 lines · Xuemin

From: xueminsu <[email protected]>
Date: Tue, 22 Jan 2013 22:16:53 +0800
Subject: [PATCH] radeon_display: Use pointer return error codes

drm_mode_addfb() expects fb_create return error code instead of NULL.

Thanks. Added to my fixes queue.

Alex

Quoted 26 lines
---
 drivers/gpu/drm/radeon/radeon_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +1 -2
index 1da2386..ff3def7 100644
@@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
        if (ret) {
                kfree(radeon_fb);
                drm_gem_object_unreference_unlocked(obj);
-               return NULL;
+               return ERR_PTR(ret);
        }
 
        return &radeon_fb->base;
--

1.7.6

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel