drm_crtc: check if fb_create return NULL
Subsystems (2)
PATCH 1/1 drm_crtc: check if fb_create return NULL
From: xueminsu <[email protected]>
Date: Tue, 22 Jan 2013 22:39:39 +0800
Subject: [PATCH] drm_crtc: check if fb_create return NULL
Some buggy driver may still return NULL in fb_create, which leads to kernel panic.
Signed-off-by xueminsu <[email protected]>
--- drivers/gpu/drm/drm_crtc.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/gpu/drm/drm_crtc.c +6 -0
@@ -2172,6 +2172,12 @@ int drm_mode_addfb(struct drm_device *dev, ret =PTR_ERR (fb); goto out; } +/* some buggy driver may return NULL here, which may cause panic */ +if (!fb) { +WARN (1 ,"%pf should not return NULL." , + dev->mode_config.funcs->fb_create); +return -EINVAL ; + } or->fb_id = fb->base.id;list_add (&fb->filp_head, &file_priv->fbs);
Signature · 1 line
1.7.6