Skip to contentSkip to conversation

drm_crtc: check if fb_create return NULL

PATCH Superseded Su, Xuemin 1 participant 1 message Jan 23, 2013

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Su, Xuemin

author
#0 lore raw

PATCH 1/1 drm_crtc: check if fb_create return NULL

From: xueminsu <[email protected]>
Date: Tue, 22 Jan 2013 22:39:39 +0800
Subject: [PATCH] drm_crtc: check if fb_create return NULL

Some buggy driver may still return NULL in fb_create, which leads to kernel panic.

---
 drivers/gpu/drm/drm_crtc.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/gpu/drm/drm_crtc.c +6 -0
index f2d667b..4ed0aed 100644
@@ -2172,6 +2172,12 @@ int drm_mode_addfb(struct drm_device *dev,
 		ret = PTR_ERR(fb);
 		goto out;
 	}
+	/* some buggy driver may return NULL here, which may cause panic */
+	if (!fb) {
+		WARN(1, "%pf should not return NULL.",
+			dev->mode_config.funcs->fb_create);
+		return -EINVAL;
+	}
 
 	or->fb_id = fb->base.id;
 	list_add(&fb->filp_head, &file_priv->fbs);
Signature · 1 line
1.7.6