Removed unused functions in st_sensors library
Hi Lars,
I have modified the functions as you tell me.
Thanks,
Denis
PATCH 1/1 iio:common: removed unused functions outside st_sensors library
This patch remove st_sensors_get_sampling_frequency_avl and st_sensors_get_scale_avl functions used only in st_sensors_sysfs_sampling_frequency_avail and st_sensors_sysfs_scale_avail sysfs functions.
--- drivers/iio/common/st_sensors/st_sensors_core.c | 70 +++++++++-------------- include/linux/iio/common/st_sensors.h | 4 -- 2 files changed, 28 insertions(+), 46 deletions(-)
drivers/iio/common/st_sensors/st_sensors_core.c +28 -42
@@ -38,46 +38,6 @@ st_sensors_write_data_with_mask_error:return err; } -int st_sensors_get_sampling_frequency_avl (struct iio_dev *indio_dev,char *buf) -{ -int i, len =0 ; -struct st_sensor_data *sdata =iio_priv (indio_dev); - -mutex_lock (&indio_dev->mlock); -for (i =0 ; i <ST_SENSORS_ODR_LIST_MAX ; i++) { -if (sdata->sensor->odr.odr_avl[i].hz ==0 ) -break ; - - len +=scnprintf (buf + len,PAGE_SIZE - len,"%d " , - sdata->sensor->odr.odr_avl[i].hz); - } -mutex_unlock (&indio_dev->mlock); - buf[len -1 ] ='\n' ; - -return len; -} -EXPORT_SYMBOL (st_sensors_get_sampling_frequency_avl); - -int st_sensors_get_scale_avl (struct iio_dev *indio_dev,char *buf) -{ -int i, len =0 ; -struct st_sensor_data *sdata =iio_priv (indio_dev); - -mutex_lock (&indio_dev->mlock); -for (i =0 ; i <ST_SENSORS_FULLSCALE_AVL_MAX ; i++) { -if (sdata->sensor->fs.fs_avl[i].num ==0 ) -break ; - - len +=scnprintf (buf + len,PAGE_SIZE - len,"0.%06u " , - sdata->sensor->fs.fs_avl[i].gain); - } -mutex_unlock (&indio_dev->mlock); - buf[len -1 ] ='\n' ; - -return len; -} -EXPORT_SYMBOL (st_sensors_get_scale_avl); -static int st_sensors_match_odr (struct st_sensors *sensor,unsigned int odr,struct st_sensor_odr_avl *odr_out) {
@@ -440,18 +400,44 @@ EXPORT_SYMBOL(st_sensors_sysfs_set_sampling_frequency);ssize_t st_sensors_sysfs_sampling_frequency_avail (struct device *dev,struct device_attribute *attr,char *buf) { +int i, len =0 ;struct iio_dev *indio_dev =dev_get_drvdata (dev); +struct st_sensor_data *sdata =iio_priv (indio_dev); + +mutex_lock (&indio_dev->mlock); +for (i =0 ; i <ST_SENSORS_ODR_LIST_MAX ; i++) { +if (sdata->sensor->odr.odr_avl[i].hz ==0 ) +break ; + + len +=scnprintf (buf + len,PAGE_SIZE - len,"%d " , + sdata->sensor->odr.odr_avl[i].hz); + } +mutex_unlock (&indio_dev->mlock); + buf[len -1 ] ='\n' ; -return st_sensors_get_sampling_frequency_avl (indio_dev, buf); +return len; }EXPORT_SYMBOL (st_sensors_sysfs_sampling_frequency_avail);ssize_t st_sensors_sysfs_scale_avail (struct device *dev,struct device_attribute *attr,char *buf) { +int i, len =0 ;struct iio_dev *indio_dev =dev_get_drvdata (dev); +struct st_sensor_data *sdata =iio_priv (indio_dev); + +mutex_lock (&indio_dev->mlock); +for (i =0 ; i <ST_SENSORS_FULLSCALE_AVL_MAX ; i++) { +if (sdata->sensor->fs.fs_avl[i].num ==0 ) +break ; + + len +=scnprintf (buf + len,PAGE_SIZE - len,"0.%06u " , + sdata->sensor->fs.fs_avl[i].gain); + } +mutex_unlock (&indio_dev->mlock); + buf[len -1 ] ='\n' ; -return st_sensors_get_scale_avl (indio_dev, buf); +return len; }EXPORT_SYMBOL (st_sensors_sysfs_scale_avail);
include/linux/iio/common/st_sensors.h +0 -4
@@ -243,10 +243,6 @@ int st_sensors_set_enable(struct iio_dev *indio_dev, bool enable);int st_sensors_set_axis_enable (struct iio_dev *indio_dev,u8 axis_enable); -int st_sensors_get_sampling_frequency_avl (struct iio_dev *indio_dev,char *buf); - -int st_sensors_get_scale_avl (struct iio_dev *indio_dev,char *buf); -int st_sensors_set_odr (struct iio_dev *indio_dev,unsigned int odr);int st_sensors_set_dataready_irq (struct iio_dev *indio_dev,bool enable);
Signature · 1 line
1.7.9.5
Jonathan Cameron
maintainerRe: [PATCH] iio:common: removed unused functions outside st_sensors library
Quoted 1 line · Denis CIOCCA
This patch remove
st_sensors_get_sampling_frequency_avlandst_sensors_get_scale_avlfunctions used only inst_sensors_sysfs_sampling_frequency_availandst_sensors_sysfs_scale_availsysfs functions.
I added your sign off to this on the assumption it was intended and applied to togreg branch of iio.git
Quoted 119 lines
--- drivers/iio/common/st_sensors/st_sensors_core.c | 70 +++++++++-------------- include/linux/iio/common/st_sensors.h | 4 -- 2 files changed, 28 insertions(+), 46 deletions(-)drivers/iio/common/st_sensors/st_sensors_core.c +28
-42@@ -38,46 +38,6 @@ st_sensors_write_data_with_mask_error:return err; } -int st_sensors_get_sampling_frequency_avl (struct iio_dev *indio_dev,char *buf) -{ -int i, len =0 ; -struct st_sensor_data *sdata =iio_priv (indio_dev); - -mutex_lock (&indio_dev->mlock); -for (i =0 ; i <ST_SENSORS_ODR_LIST_MAX ; i++) { -if (sdata->sensor->odr.odr_avl[i].hz ==0 ) -break ; - - len +=scnprintf (buf + len,PAGE_SIZE - len,"%d " , - sdata->sensor->odr.odr_avl[i].hz); - } -mutex_unlock (&indio_dev->mlock); - buf[len -1 ] ='\n' ; - -return len; -} -EXPORT_SYMBOL (st_sensors_get_sampling_frequency_avl); - -int st_sensors_get_scale_avl (struct iio_dev *indio_dev,char *buf) -{ -int i, len =0 ; -struct st_sensor_data *sdata =iio_priv (indio_dev); - -mutex_lock (&indio_dev->mlock); -for (i =0 ; i <ST_SENSORS_FULLSCALE_AVL_MAX ; i++) { -if (sdata->sensor->fs.fs_avl[i].num ==0 ) -break ; - - len +=scnprintf (buf + len,PAGE_SIZE - len,"0.%06u " , - sdata->sensor->fs.fs_avl[i].gain); - } -mutex_unlock (&indio_dev->mlock); - buf[len -1 ] ='\n' ; - -return len; -} -EXPORT_SYMBOL (st_sensors_get_scale_avl); -static int st_sensors_match_odr (struct st_sensors *sensor,unsigned int odr,struct st_sensor_odr_avl *odr_out) {@@ -440,18 +400,44 @@ EXPORT_SYMBOL(st_sensors_sysfs_set_sampling_frequency);ssize_t st_sensors_sysfs_sampling_frequency_avail (struct device *dev,struct device_attribute *attr,char *buf) { +int i, len =0 ;struct iio_dev *indio_dev =dev_get_drvdata (dev); +struct st_sensor_data *sdata =iio_priv (indio_dev); + +mutex_lock (&indio_dev->mlock); +for (i =0 ; i <ST_SENSORS_ODR_LIST_MAX ; i++) { +if (sdata->sensor->odr.odr_avl[i].hz ==0 ) +break ; + + len +=scnprintf (buf + len,PAGE_SIZE - len,"%d " , + sdata->sensor->odr.odr_avl[i].hz); + } +mutex_unlock (&indio_dev->mlock); + buf[len -1 ] ='\n' ; -return st_sensors_get_sampling_frequency_avl (indio_dev, buf); +return len; }EXPORT_SYMBOL (st_sensors_sysfs_sampling_frequency_avail);ssize_t st_sensors_sysfs_scale_avail (struct device *dev,struct device_attribute *attr,char *buf) { +int i, len =0 ;struct iio_dev *indio_dev =dev_get_drvdata (dev); +struct st_sensor_data *sdata =iio_priv (indio_dev); + +mutex_lock (&indio_dev->mlock); +for (i =0 ; i <ST_SENSORS_FULLSCALE_AVL_MAX ; i++) { +if (sdata->sensor->fs.fs_avl[i].num ==0 ) +break ; + + len +=scnprintf (buf + len,PAGE_SIZE - len,"0.%06u " , + sdata->sensor->fs.fs_avl[i].gain); + } +mutex_unlock (&indio_dev->mlock); + buf[len -1 ] ='\n' ; -return st_sensors_get_scale_avl (indio_dev, buf); +return len; }EXPORT_SYMBOL (st_sensors_sysfs_scale_avail);include/linux/iio/common/st_sensors.h +0
-4@@ -243,10 +243,6 @@ int st_sensors_set_enable(struct iio_dev *indio_dev, bool enable);int st_sensors_set_axis_enable (struct iio_dev *indio_dev,u8 axis_enable); -int st_sensors_get_sampling_frequency_avl (struct iio_dev *indio_dev,char *buf); - -int st_sensors_get_scale_avl (struct iio_dev *indio_dev,char *buf); -int st_sensors_set_odr (struct iio_dev *indio_dev,unsigned int odr);int st_sensors_set_dataready_irq (struct iio_dev *indio_dev,bool enable);