regulator: tps65090: Fix using wrong dev argument for calling of_regulator_match
PATCH 1/1 regulator: tps65090: Fix using wrong dev argument for calling of_regulator_match
The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.
The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus it should be freed when this driver is unloaded.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/tps65090-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/tps65090-regulator.c +1 -1
@@ -186,7 +186,7 @@ static struct tps65090_platform_data *tps65090_parse_dt_reg_data(return ERR_PTR (-ENODEV ); } - ret =of_regulator_match (pdev->dev.parent, regulators, tps65090_matches, + ret =of_regulator_match (&pdev->dev, regulators, tps65090_matches,ARRAY_SIZE (tps65090_matches));if (ret <0 ) { dev_err(&pdev->dev,
Signature · 1 line
1.7.9.5
Mark Brown
AppliedQuoted 2 lines · Axel Lin
The dev parameter is the device requesting the data.
In this case it should be&pdev->devrather thanpdev->dev.parent.
Applied, thanks.