Skip to contentSkip to conversation

ASoC: Ux500: Fix build error pertaining to missing include file

PATCH In review Lee Jones 2 participants 9 messages Jan 31, 2013

Subsystems (2)
lore
Share & tools
lore

Lee Jones

author
#0 lore raw

PATCH 1/1 ASoC: Ux500: Fix build error pertaining to missing include file

Some compilers complain when building sound for MOP500:

sound/soc/ux500/mop500.c:27:27:
fatal error: mop500_ab8500.h: No such file or directory

That file is actually in the local directory rather than include.

---
 sound/soc/ux500/mop500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/ux500/mop500.c +1 -1
index ae69907..204b899 100644
@@ -24,7 +24,7 @@
 #include "ux500_pcm.h"
 #include "ux500_msp_dai.h"
 
-#include <mop500_ab8500.h>
+#include "mop500_ab8500.h"
 
 /* Define the whole MOP500 soundcard, linking platform to the codec-drivers  */
 struct snd_soc_dai_link mop500_dai_links[] = {
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 4 lines · Lee Jones

Some compilers complain when building sound for MOP500:

sound/soc/ux500/mop500.c:27:27:
fatal error: mop500_ab8500.h: No such file or directory

Should be kernel version dependant I expect...

author
#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 4 lines · Lee Jones

Some compilers complain when building sound for MOP500:

sound/soc/ux500/mop500.c:27:27:
fatal error: mop500_ab8500.h: No such file or directory

Should be kernel version dependant I expect...

What do you mean?

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw
Quoted 11 lines · Lee Jones
Quoted 8 lines · Mark Brown
Quoted 4 lines · Lee Jones

Some compilers complain when building sound for MOP500:

sound/soc/ux500/mop500.c:27:27:
fatal error: mop500_ab8500.h: No such file or directory

Should be kernel version dependant I expect...

What do you mean?

I'm a bit surprised the compiler would change something like that, I'd expect it to be more the build system.

author
#4 lore raw
Quoted 9 lines · Mark Brown
Quoted 7 lines · Lee Jones
Quoted 6 lines · Mark Brown
Quoted 4 lines · Lee Jones

Some compilers complain when building sound for MOP500:

sound/soc/ux500/mop500.c:27:27:
fatal error: mop500_ab8500.h: No such file or directory

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Should be kernel version dependant I expect...

What do you mean?

I'm a bit surprised the compiler would change something like that, I'd expect it to be more the build system.

You've lost me.

When I compile this file it succeeds. When the person who reported this bug compiles, it fails with the error above.

mop500_ab8500.h is actually in the same directory as the file including it, so it should by rights be encapsulated in "" and not <>, right?

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
Quoted 5 lines · Lee Jones
Quoted 2 lines · Mark Brown

I'm a bit surprised the compiler would change something like that, I'd expect it to be more the build system.

Quoted 8 lines

You've lost me.

When I compile this file it succeeds. When the person who reported this bug compiles, it fails with the error above.

mop500_ab8500.h is actually in the same directory as the file including it, so it should by rights be encapsulated in "" and not <>, right?

Yes, it should - but this is also something that can be overridden by the build system. It'd seem surprising for a compiler vendor to change their behaviour here as there's limited benefit in changing and much potential for error.

author
#6 lore raw
Quoted 11 lines · Mark Brown
Quoted 9 lines · Lee Jones
Quoted 2 lines · Mark Brown

I'm a bit surprised the compiler would change something like that, I'd expect it to be more the build system.

You've lost me.

When I compile this file it succeeds. When the person who reported this bug compiles, it fails with the error above.

Quoted 8 lines
Quoted 3 lines

mop500_ab8500.h is actually in the same directory as the file including it, so it should by rights be encapsulated in "" and not <>, right?

Yes, it should - but this is also something that can be overridden by the build system. It'd seem surprising for a compiler vendor to change their behaviour here as there's limited benefit in changing and much potential for error.

Ah, got you.

Are you going to take the patch?

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#7 lore raw
Quoted 1 line · Lee Jones

Are you going to take the patch?

Yes, I applied it when I sent the original reply.

author
#8 lore raw
Quoted 5 lines · Mark Brown
Quoted 1 line · Lee Jones

Are you going to take the patch?

Yes, I applied it when I sent the original reply.

Perfect, thanks Mark.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog