Skip to contentSkip to conversation

Added comments to explain watchdog_disabled variable

PATCH In review anish kumar 1 participant 2 messages Feb 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Added comments to explain watchdog_disabled variable

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/watchdog.c +1 -0
index 75a2ab3..6ef638b 100644
@@ -155,6 +155,7 @@ void touch_all_softlockup_watchdogs(void)
 	for_each_online_cpu(cpu)
 		per_cpu(watchdog_touch_ts, cpu) = 0;
 }
+EXPORT_SYMBOL(touch_all_softlockup_watchdogs);
 
 #ifdef CONFIG_HARDLOCKUP_DETECTOR
 void touch_nmi_watchdog(void)
Signature · 1 line
1.7.1
#1 lore raw

Please ignore this patch.

Quoted 26 lines · anish kumar

From: anish kumar <[email protected]>

This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.

---
 kernel/watchdog.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/watchdog.c +1 -0
index 75a2ab3..6ef638b 100644
@@ -155,6 +155,7 @@ void touch_all_softlockup_watchdogs(void)
 	for_each_online_cpu(cpu)
 		per_cpu(watchdog_touch_ts, cpu) = 0;
 }
+EXPORT_SYMBOL(touch_all_softlockup_watchdogs);
 
 #ifdef CONFIG_HARDLOCKUP_DETECTOR
 void touch_nmi_watchdog(void)