Skip to contentSkip to conversation

iio:imu:inv Suggested trivial fixups for the submitted patch.

PATCH New Jonathan Cameron 1 participant 1 message Feb 2, 2013

Subsystems (2)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio:imu:inv Suggested trivial fixups for the submitted patch.

Not signed off on basis I would like these merged into the original patch and then a new version of that sent out.

---
 Documentation/ABI/testing/sysfs-bus-iio-mpu6050  |  1 -
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c       | 45 ++++++++++++++----------
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h        |  1 -
 drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c       | 14 ++++----
 drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c    |  6 ++--
 include/linux/platform_data/invensense_mpu6050.h |  1 -
 6 files changed, 39 insertions(+), 29 deletions(-)
Documentation/ABI/testing/sysfs-bus-iio-mpu6050 +0 -1
index d4ec747..cb53737 100644
@@ -11,4 +11,3 @@ Description:
 		positions relative to the board that holds these sensors. Identity matrix
 		[1, 0, 0; 0, 1, 0; 0, 0, 1] means sensor chip and device are perfectly
 		aligned with each other. All axes are exactly the same.
-
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +27 -18

107 lines not on this page · raw message

drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +0 -1
index 34cd054..f383955 100644
@@ -244,4 +244,3 @@ int inv_reset_fifo(struct iio_dev *indio_dev);
 int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask);
 int inv_mpu6050_write_reg(struct inv_mpu6050_state *st, int reg, u8 val);
 int inv_mpu6050_set_power_itg(struct inv_mpu6050_state *st, bool power_on);
-
drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c +8 -6
index e1deee4..331781f 100644
@@ -94,8 +94,8 @@ static void inv_clear_kfifo(struct inv_mpu6050_state *st)
 	spin_unlock_irqrestore(&st->time_stamp_lock, flags);
 }
 
-/*
- *  inv_mpu6050_irq_handler() - Cache a timestamp at each data ready interrupt.
+/**
+ * inv_mpu6050_irq_handler() - Cache a timestamp at each data ready interrupt.
  */
 irqreturn_t inv_mpu6050_irq_handler(int irq, void *p)
 {
@@ -112,8 +112,8 @@ irqreturn_t inv_mpu6050_irq_handler(int irq, void *p)
 	return IRQ_WAKE_THREAD;
 }
 
-/*
- *  inv_mpu6050_read_fifo() - Transfer data from hardware FIFO to KFIFO.
+/**
+ * inv_mpu6050_read_fifo() - Transfer data from hardware FIFO to KFIFO.
  */
 irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
 {
@@ -138,8 +138,10 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
 	if (st->chip_config.gyro_fifo_enable)
 		bytes_per_datum += INV_MPU6050_BYTES_PER_3AXIS_SENSOR;
 
-	/* read fifo_count register to know how many bytes inside FIFO
-	   right now */
+	/*
+	 * read fifo_count register to know how many bytes inside FIFO
+	 * right now
+	 */
 	result = i2c_smbus_read_i2c_block_data(st->client,
 				       st->reg->fifo_count_h,
 				       INV_MPU6050_FIFO_COUNT_BYTE, data);
drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c +4 -2
index 6f62caf..e1d0869 100644
@@ -95,8 +95,10 @@ static int inv_mpu6050_set_enable(struct iio_dev *indio_dev, bool enable)
 	return 0;
 }
 
-/*
- * inv_mpu_data_rdy_trigger_set_state() set data ready interrupt state
+/**
+ * inv_mpu_data_rdy_trigger_set_state() - set data ready interrupt state
+ * @trig: Trigger instance
+ * @state: Desired trigger state
  */
 static int inv_mpu_data_rdy_trigger_set_state(struct iio_trigger *trig,
 						bool state)
include/linux/platform_data/invensense_mpu6050.h +0 -1
index 2303d65..ad3aa7b 100644
@@ -9,7 +9,6 @@
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
-*
 */
 
 #ifndef __INV_MPU6050_PLATFORM_H_
Signature · 1 line
1.8.1.1