Skip to contentSkip to conversation

wpa-supplicant: Package systemd service in -systemd

PATCH NAK Andrei Gherzan 3 participants 4 messages Feb 5, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wpa-supplicant: Package systemd service in -systemd

---
 .../wpa-supplicant/wpa-supplicant-2.0.inc          |    6 ++++--
 .../wpa-supplicant/wpa-supplicant_2.0.bb           |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc +4 -2
index 89910a0..7ce85a6 100644
@@ -18,10 +18,12 @@ SRC_URI = "http://hostap.epitest.fi/releases/wpa_supplicant-${PV}.tar.gz \
 
 S = "${WORKDIR}/wpa_supplicant-${PV}/wpa_supplicant"
 
-PACKAGES_prepend = "wpa-supplicant-passphrase wpa-supplicant-cli "
+PACKAGES_prepend = "wpa-supplicant-passphrase wpa-supplicant-cli wpa-supplicant-systemd "
 FILES_wpa-supplicant-passphrase = "${bindir}/wpa_passphrase"
 FILES_wpa-supplicant-cli = "${sbindir}/wpa_cli"
-FILES_${PN} += "${datadir}/dbus-1/system-services/* ${systemd_unitdir}/system/*"
+FILES_wpa-supplicant-systemd = "${systemd_unitdir}/system/*"
+FILES_${PN} += "${datadir}/dbus-1/system-services/*"
+
 CONFFILES_${PN} += "${sysconfdir}/wpa_supplicant.conf"
 
 do_configure () {
meta/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bb +1 -1
index 22e42dd..a8b0dad 100644
@@ -1,6 +1,6 @@
 require wpa-supplicant-2.0.inc
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI[md5sum] = "3be2ebfdcced52e00eda0afe2889839d"
 SRC_URI[sha256sum] = "2c115609fbb5223d51381084a5c944455a8afcda81d584173ff55ba233379e09"
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 5 lines · Andrei Gherzan
---
 .../wpa-supplicant/wpa-supplicant-2.0.inc          |    6 ++++--
 .../wpa-supplicant/wpa-supplicant_2.0.bb           |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

NACK.

Please don't add -systemd packages. I've almost got a systemd.bbclass that I'm happy with, but if you must add integration now then just package the unit files alongside the daemons, respecting the distro feature.

Ross

#2 lore raw
Quoted 7 lines · Ross
Quoted 5 lines · Andrei Gherzan
---
 .../wpa-supplicant/wpa-supplicant-2.0.inc          |    6 ++++--
 .../wpa-supplicant/wpa-supplicant_2.0.bb           |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
Quoted 6 lines

NACK.

Please don't add -systemd packages. I've almost got a systemd.bbclass that I'm happy with, but if you must add integration now then just package the unit files alongside the daemons, respecting the distro feature.

I'd prefer to hold it until the class is out.

--
Otavio Salvador O.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

#3 lore raw
Quoted 8 lines · Otavio Salvador
Quoted 7 lines · Ross
Quoted 5 lines · Andrei Gherzan
---
 .../wpa-supplicant/wpa-supplicant-2.0.inc          |    6 ++++--
 .../wpa-supplicant/wpa-supplicant_2.0.bb           |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
Quoted 9 lines
Quoted 6 lines

NACK.

Please don't add -systemd packages. I've almost got a systemd.bbclass that I'm happy with, but if you must add integration now then just package the unit files alongside the daemons, respecting the distro feature.

I'd prefer to hold it until the class is out.

Fair.

--
Andrei Gherzan | Wind River Systems
m: +40 734 450 615 | p: +40 236 320 307