new IGEP board support
cover new IGEP board support
From: Enric Balletbo i Serra <[email protected]>
Hi all,
In our effort to mainline the IGEP device support here are two patches to add support to the IGEP COM PROTON board. The first patch is only a trivial patch that changes some IGEP boards names. The second is to add the new board.
These patches applies on top of u-boot-ti repository as the following patch is required.
OMAP3: use a single board file for IGEP devices
commit 076be4528851126b56f2c1b84d07834297797f6c
From Javier Martinez Canillas
Best regards,
Enric Balletbo i Serra (2):
OMAP3: igep00x0: use official board names.
OMAP3: igep00x0: Add new IGEP COM PROTON.
MAINTAINERS | 1 + board/isee/igep00x0/igep00x0.c | 3 +++ board/isee/igep00x0/igep00x0.h | 7 +++++-- boards.cfg | 1 + 4 files changed, 10 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.10.4
PATCH 1/2 OMAP3: igep00x0: use official board names.
From: Enric Balletbo i Serra <[email protected]>
This trivial patch only changes current boards names for the official names.
--- board/isee/igep00x0/igep00x0.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
board/isee/igep00x0/igep00x0.h +2 -2
@@ -34,10 +34,10 @@const omap3_sysinfo sysinfo = {DDR_STACKED , #if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) -"OMAP3 IGEP v2 board" , +"IGEPv2" , #endif #if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030) -"OMAP3 IGEP COM Module" , +"IGEP COM MODULE/ELECTRON" , #endif #if defined(CONFIG_ENV_IS_IN_ONENAND) "ONENAND",
Signature · 1 line
1.7.10.4
PATCH 2/2 OMAP3: igep00x0: Add new IGEP COM PROTON.
In reply to Enric Balletbo i SerraFrom: Enric Balletbo i Serra <[email protected]>
The IGEP COM PROTON is a new ultra compact module design with an on-board ethernet controller.
--- MAINTAINERS | 1 + board/isee/igep00x0/igep00x0.c | 3 +++ board/isee/igep00x0/igep00x0.h | 3 +++ boards.cfg | 1 + 4 files changed, 8 insertions(+)
MAINTAINERS +1 -0
@@ -607,6 +607,7 @@ Enric Balletbo i Serra <[email protected]> igep0020 ARM ARMV7 (OMAP3xx SoC) igep0030 ARM ARMV7 (OMAP3xx SoC) + igep0032 ARM ARMV7 (OMAP3xx SoC) Eric Benard <[email protected]>
board/isee/igep00x0/igep00x0.c +3 -0
@@ -68,8 +68,11 @@ void show_boot_progress(int val) return; } +/* Skip in the case of IGEP0032 machine */ +#if !(CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )if (!gpio_request (IGEP00X0_GPIO_LED ,"" ))gpio_direction_output (IGEP00X0_GPIO_LED ,1 ); +#endif }#endif
board/isee/igep00x0/igep00x0.h +3 -0
@@ -39,6 +39,9 @@ const omap3_sysinfo sysinfo = {#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 ) "IGEP COM MODULE/ELECTRON",#endif +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 ) + "IGEP COM PROTON", +#endif #if defined(CONFIG_ENV_IS_IN_ONENAND ) "ONENAND",#else
boards.cfg +1 -0
@@ -259,6 +259,7 @@ igep0020 arm armv7 igep00x0 isee igep0020_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND +igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND am3517_evm arm armv7 am3517evm logicpd omap3 mt_ventoux arm armv7 mt_ventoux teejet omap3 omap3_zoom1 arm armv7 zoom1 logicpd omap3
Signature · 1 line
1.7.10.4
PATCH 2/2 OMAP3: igep00x0: Add new IGEP COM PROTON.
Hi Enric,
Quoted 31 lines · Enric Balletbo i Serra
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM PROTON is a new ultra compact module design with an on-board ethernet controller.
Signed-off-by Enric Balletbo i Serra <[email protected]>--- MAINTAINERS | 1 + board/isee/igep00x0/igep00x0.c | 3 +++ board/isee/igep00x0/igep00x0.h | 3 +++ boards.cfg | 1 + 4 files changed, 8 insertions(+)MAINTAINERS +1
-0@@ -607,6 +607,7 @@ Enric Balletbo i Serra <[email protected]> igep0020 ARM ARMV7 (OMAP3xx SoC) igep0030 ARM ARMV7 (OMAP3xx SoC) + igep0032 ARM ARMV7 (OMAP3xx SoC) Eric Benard <[email protected]>board/isee/igep00x0/igep00x0.c +0
-0@@ -68,8 +68,11 @@ void show_boot_progress(int val)return ;
board/isee/igep00x0/igep00x0.c void show_boot_progress(int val) · line 78
Quoted 10 lines
board/isee/igep00x0/igep00x0.c +3
-0} +/* Skip in the case of IGEP0032 machine */ +#if !(CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )if (!gpio_request (IGEP00X0_GPIO_LED ,"" ))gpio_direction_output (IGEP00X0_GPIO_LED ,1 ); +#endif }#endif
So, this board doesn't have a GPIO LED to show it boot status?
If that's the case I think there is no point to call show_boot_progress(). Since this function is only compiled when CONFIG_SHOW_BOOT_PROGRESS is defined. I think that a better approach is to just define it for the machines that have a boot progress GPIO LED. e.g:
include/configs/igep00x0.h +3 -0
@@ -85,8 +85,11 @@#define CONFIG_OMAP_HSMMC 1#define CONFIG_DOS_PARTITION 1 +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 )/* define to enable boot progress via leds */ #define CONFIG_SHOW_BOOT_PROGRESS +#endif /* USB */ #define CONFIG_MUSB_UDC 1
Quoted 19 lines
board/isee/igep00x0/igep00x0.h +3
-0@@ -39,6 +39,9 @@ const omap3_sysinfo sysinfo = {#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 ) "IGEP COM MODULE/ELECTRON",#endif +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 ) + "IGEP COM PROTON", +#endif #if defined(CONFIG_ENV_IS_IN_ONENAND ) "ONENAND",#else boards.cfg +0
-0
boards.cfg igep0020 arm armv7 igep00x0 isee
Quoted 8 lines
boards.cfg +1
-1@@ -259,6 +259,7 @@ igep0020 arm armv7 igep00x0 isee igep0020_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND +igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND am3517_evm arm armv7 am3517evm logicpd omap3 mt_ventoux arm armv7 mt_ventoux teejet omap3 omap3_zoom1 arm armv7 zoom1 logicpd omap3 --
This doesn't have a NAND version too like IGEP0020 and IGEP0030 boards?
You said that this board has an on-board ethernet controller. Does this board use the
SMC911X chip connected to the OMAP GPMC too? In that case I guess you need something like this to have CONFIG_CMD_NET enabled on board/isee/igep00x0/igep00x0.c
for this board too:
include/configs/igep00x0.h +2 -1
@@ -118,7 +118,8 @@#ifdef CONFIG_BOOT_NAND #define CONFIG_CMD_NAND #endif -#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )#define CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */ #endif #define CONFIG_CMD_DHCP
Thanks a lot and best regards,
Javier
PATCH 2/2 OMAP3: igep00x0: Add new IGEP COM PROTON.
Hi Javier,
Thanks for your comments.
2013/2/6 Javier Martinez Canillas <[email protected]>:
Quoted 37 lines
Hi Enric,
Quoted 33 lines · Enric Balletbo i Serra
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM PROTON is a new ultra compact module design with an on-board ethernet controller.
Signed-off-by Enric Balletbo i Serra <[email protected]>--- MAINTAINERS | 1 + board/isee/igep00x0/igep00x0.c | 3 +++ board/isee/igep00x0/igep00x0.h | 3 +++ boards.cfg | 1 + 4 files changed, 8 insertions(+)MAINTAINERS +1
-0@@ -607,6 +607,7 @@ Enric Balletbo i Serra <[email protected]> igep0020 ARM ARMV7 (OMAP3xx SoC) igep0030 ARM ARMV7 (OMAP3xx SoC) + igep0032 ARM ARMV7 (OMAP3xx SoC) Eric Benard <[email protected]>board/isee/igep00x0/igep00x0.c +0
-0@@ -68,8 +68,11 @@ void show_boot_progress(int val)return ; }
Quoted 11 lines
board/isee/igep00x0/igep00x0.c void show_boot_progress(int val) · line 78
Quoted 8 lines
board/isee/igep00x0/igep00x0.c +3
-0+/* Skip in the case of IGEP0032 machine */ +#if !(CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )if (!gpio_request (IGEP00X0_GPIO_LED ,"" ))gpio_direction_output (IGEP00X0_GPIO_LED ,1 ); +#endif }#endif So, this board doesn't have a GPIO LED to show it boot status?
Yes, it has but not connected to one OMAP GPIO. There is a led to indicate power and two leds connected to TWL. Maybe I could use one of them but meanwhile I decided don't use these leds.
Quoted 10 lines
If that's the case I think there is no point to call
show_boot_progress(). Since this function is only compiled whenCONFIG_SHOW_BOOT_PROGRESSis defined. I think that a better approach is to just define it for the machines that have a boot progress GPIO LED. e.g:include/configs/igep00x0.h +0
-0
include/configs/igep00x0.h line 93
Quoted 9 lines
include/configs/igep00x0.h +3
-0@@ -85,8 +85,11 @@#define CONFIG_OMAP_HSMMC 1#define CONFIG_DOS_PARTITION 1 +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 )/* define to enable boot progress via leds */ #define CONFIG_SHOW_BOOT_PROGRESS +#endif
The problem is: if I disable the call to show_boot_progress in igep00x0.h I'll get a compilation error in this function because IGEP00X0_GPIO_LED is undeclared, so necessarily I need to protect the call in igep00x0.c against this undefined reference. For that reason I used the ifdef inside the show_boot_progress implementation.
Quoted 24 lines
include/configs/igep00x0.h +0
-0/* USB */ #define CONFIG_MUSB_UDC 1Quoted 22 lines
board/isee/igep00x0/igep00x0.h +3
-0@@ -39,6 +39,9 @@ const omap3_sysinfo sysinfo = {#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 ) "IGEP COM MODULE/ELECTRON",#endif +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 ) + "IGEP COM PROTON", +#endif #if defined(CONFIG_ENV_IS_IN_ONENAND ) "ONENAND",#else boards.cfg +0
-0@@ -259,6 +259,7 @@ igep0020 arm armv7 igep00x0 isee igep0020_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND
Quoted 9 lines
boards.cfg igep0020 arm armv7 igep00x0 isee
Quoted 6 lines
boards.cfg +1
-1igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND +igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND am3517_evm arm armv7 am3517evm logicpd omap3 mt_ventoux arm armv7 mt_ventoux teejet omap3 omap3_zoom1 arm armv7 zoom1 logicpd omap3 --This doesn't have a NAND version too like IGEP0020 and IGEP0030 boards?
No, the IGEP0032 only has OneNAND.
Quoted 13 lines
You said that this board has an on-board ethernet controller. Does this board use the
SMC911X chip connected to the OMAP GPMC too? In that case I guess you need something like this to haveCONFIG_CMD_NETenabled onboard/isee/igep00x0/igep00x0.c
for this board too:include/configs/igep00x0.h +0
-0
include/configs/igep00x0.h line 125
Quoted 9 lines
include/configs/igep00x0.h +2
-1@@ -118,7 +118,8 @@#ifdef CONFIG_BOOT_NAND #define CONFIG_CMD_NAND #endif -#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )#define CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */ #endif #define CONFIG_CMD_DHCP
Right, I'll add this in version 2.
Thanks and best regards,
Enric
Quoted 2 lines
Thanks a lot and best regards,
Javier
PATCH 2/2 OMAP3: igep00x0: Add new IGEP COM PROTON.
Quoted 2 lines · Enric Balletbo Serra
Hi Javier,
Hi Enric,
Quoted 52 lines
Thanks for your comments.
2013/2/6 Javier Martinez Canillas <[email protected]>:
Quoted 37 lines
Hi Enric,
Quoted 33 lines · Enric Balletbo i Serra
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM PROTON is a new ultra compact module design with an on-board ethernet controller.
Signed-off-by Enric Balletbo i Serra <[email protected]>--- MAINTAINERS | 1 + board/isee/igep00x0/igep00x0.c | 3 +++ board/isee/igep00x0/igep00x0.h | 3 +++ boards.cfg | 1 + 4 files changed, 8 insertions(+)MAINTAINERS +1
-0@@ -607,6 +607,7 @@ Enric Balletbo i Serra <[email protected]> igep0020 ARM ARMV7 (OMAP3xx SoC) igep0030 ARM ARMV7 (OMAP3xx SoC) + igep0032 ARM ARMV7 (OMAP3xx SoC) Eric Benard <[email protected]>board/isee/igep00x0/igep00x0.c +0
-0@@ -68,8 +68,11 @@ void show_boot_progress(int val)return ; }Quoted 11 lines
board/isee/igep00x0/igep00x0.c void show_boot_progress(int val) · line 78
Quoted 8 lines
board/isee/igep00x0/igep00x0.c +3
-0+/* Skip in the case of IGEP0032 machine */ +#if !(CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )if (!gpio_request (IGEP00X0_GPIO_LED ,"" ))gpio_direction_output (IGEP00X0_GPIO_LED ,1 ); +#endif }#endif So, this board doesn't have a GPIO LED to show it boot status?
Quoted 4 lines
Yes, it has but not connected to one OMAP GPIO. There is a led to indicate power and two leds connected to TWL. Maybe I could use one of them but meanwhile I decided don't use these leds.
Agree
Quoted 13 lines
Quoted 13 lines
If that's the case I think there is no point to call
show_boot_progress(). Since this function is only compiled whenCONFIG_SHOW_BOOT_PROGRESSis defined. I think that a better approach is to just define it for the machines that have a boot progress GPIO LED. e.g:include/configs/igep00x0.h +0
-0@@ -85,8 +85,11 @@#define CONFIG_OMAP_HSMMC 1#define CONFIG_DOS_PARTITION 1
Quoted 13 lines
include/configs/igep00x0.h line 93
Quoted 6 lines
include/configs/igep00x0.h +3
-0+#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 )/* define to enable boot progress via leds */ #define CONFIG_SHOW_BOOT_PROGRESS +#endif The problem is: if I disable the call to
show_boot_progressinigep00x0.hI'll get a compilation error in this function becauseIGEP00X0_GPIO_LEDis undeclared, so necessarily I need to protect the call inigep00x0.cagainst this undefined reference. For that reason I used the ifdef inside theshow_boot_progressimplementation.
I'm confused now, why would that happen?
IGEP00X0_GPIO_LED is only used in show_boot_progress and this function his shielded by:
#if defined(CONFIG_SHOW_BOOT_PROGRESS) && !defined(CONFIG_SPL_BUILD) void show_boot_progress(int val)
{
if (val < 0) {
/* something went wrong */
return;
}
if (!gpio_request(IGEP00X0_GPIO_LED, ""))
gpio_direction_output(IGEP00X0_GPIO_LED, 1);
}#endif
Which means that this function is only build whenCONFIG_SHOW_BOOT_PROGRESS is defined.
So, I don't see why not defining CONFIG_SHOW_BOOT_PROGRESS for MACH_TYPE_IGEP0032
could lead to that build error (after all IGEP00X0_GPIO_LED is not been used in any other place)
Quoted 34 lines
Quoted 24 lines
include/configs/igep00x0.h +0
-0/* USB */ #define CONFIG_MUSB_UDC 1Quoted 22 lines
board/isee/igep00x0/igep00x0.h +3
-0@@ -39,6 +39,9 @@ const omap3_sysinfo sysinfo = {#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 ) "IGEP COM MODULE/ELECTRON",#endif +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 ) + "IGEP COM PROTON", +#endif #if defined(CONFIG_ENV_IS_IN_ONENAND ) "ONENAND",#else boards.cfg +0
-0@@ -259,6 +259,7 @@ igep0020 arm armv7 igep00x0 isee igep0020_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENANDQuoted 9 lines
boards.cfg igep0020 arm armv7 igep00x0 isee
Quoted 6 lines
boards.cfg +1
-1igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND +igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND am3517_evm arm armv7 am3517evm logicpd omap3 mt_ventoux arm armv7 mt_ventoux teejet omap3 omap3_zoom1 arm armv7 zoom1 logicpd omap3 --This doesn't have a NAND version too like IGEP0020 and IGEP0030 boards?
Quoted 2 lines
No, the IGEP0032 only has OneNAND.
Perfect, I just asked since other IGEP boards used both flash memory types.
Quoted 16 lines
Quoted 16 lines
You said that this board has an on-board ethernet controller. Does this board use the
SMC911X chip connected to the OMAP GPMC too? In that case I guess you need something like this to haveCONFIG_CMD_NETenabled onboard/isee/igep00x0/igep00x0.c
for this board too:include/configs/igep00x0.h +0
-1@@ -118,7 +118,8 @@#ifdef CONFIG_BOOT_NAND #define CONFIG_CMD_NAND #endif -#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 )
Quoted 9 lines
include/configs/igep00x0.h line 125
Quoted 6 lines
include/configs/igep00x0.h +2
-0+#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )#define CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */ #endif #define CONFIG_CMD_DHCP Right, I'll add this in version 2.
Great
Quoted 3 lines
Thanks and best regards,
Enric
Thanks a lot and best regards,
Javier
PATCH 2/2 OMAP3: igep00x0: Add new IGEP COM PROTON.
Hi Javier,
2013/2/6 Javier Martinez Canillas <[email protected]>:
Quoted 111 lines
Quoted 2 lines · Enric Balletbo Serra
Hi Javier,
Hi Enric,
Quoted 52 lines
Thanks for your comments.
2013/2/6 Javier Martinez Canillas <[email protected]>:
Quoted 37 lines
Hi Enric,
Quoted 33 lines · Enric Balletbo i Serra
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM PROTON is a new ultra compact module design with an on-board ethernet controller.
Signed-off-by Enric Balletbo i Serra <[email protected]>--- MAINTAINERS | 1 + board/isee/igep00x0/igep00x0.c | 3 +++ board/isee/igep00x0/igep00x0.h | 3 +++ boards.cfg | 1 + 4 files changed, 8 insertions(+)MAINTAINERS +1
-0@@ -607,6 +607,7 @@ Enric Balletbo i Serra <[email protected]> igep0020 ARM ARMV7 (OMAP3xx SoC) igep0030 ARM ARMV7 (OMAP3xx SoC) + igep0032 ARM ARMV7 (OMAP3xx SoC) Eric Benard <[email protected]>board/isee/igep00x0/igep00x0.c +0
-0@@ -68,8 +68,11 @@ void show_boot_progress(int val)return ; }Quoted 11 lines
board/isee/igep00x0/igep00x0.c void show_boot_progress(int val) · line 78
Quoted 8 lines
board/isee/igep00x0/igep00x0.c +3
-0+/* Skip in the case of IGEP0032 machine */ +#if !(CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )if (!gpio_request (IGEP00X0_GPIO_LED ,"" ))gpio_direction_output (IGEP00X0_GPIO_LED ,1 ); +#endif }#endif So, this board doesn't have a GPIO LED to show it boot status?
Quoted 4 lines
Yes, it has but not connected to one OMAP GPIO. There is a led to indicate power and two leds connected to TWL. Maybe I could use one of them but meanwhile I decided don't use these leds.
Agree
Quoted 13 lines
Quoted 13 lines
If that's the case I think there is no point to call
show_boot_progress(). Since this function is only compiled whenCONFIG_SHOW_BOOT_PROGRESSis defined. I think that a better approach is to just define it for the machines that have a boot progress GPIO LED. e.g:include/configs/igep00x0.h +0
-0@@ -85,8 +85,11 @@#define CONFIG_OMAP_HSMMC 1#define CONFIG_DOS_PARTITION 1Quoted 13 lines
include/configs/igep00x0.h line 93
Quoted 6 lines
include/configs/igep00x0.h +3
-0+#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 )/* define to enable boot progress via leds */ #define CONFIG_SHOW_BOOT_PROGRESS +#endif The problem is: if I disable the call to
show_boot_progressinigep00x0.hI'll get a compilation error in this function becauseIGEP00X0_GPIO_LEDis undeclared, so necessarily I need to protect the call inigep00x0.cagainst this undefined reference. For that reason I used the ifdef inside theshow_boot_progressimplementation.I'm confused now, why would that happen?
IGEP00X0_GPIO_LEDis only used inshow_boot_progressand this function his shielded by:#if
defined(CONFIG_SHOW_BOOT_PROGRESS)&& !defined(CONFIG_SPL_BUILD) voidshow_boot_progress(int val){ if (val < 0) { /* something went wrong */ return; } if (!gpio_request(IGEP00X0_GPIO_LED, "")) gpio_direction_output(IGEP00X0_GPIO_LED, 1); }#endif
Quoted 8 lines
Which means that this function is only build when
CONFIG_SHOW_BOOT_PROGRESSis defined.So, I don't see why not defining
CONFIG_SHOW_BOOT_PROGRESSforMACH_TYPE_IGEP0032
could lead to that build error (after allIGEP00X0_GPIO_LEDis not been used in any other place)
Mmmm, right you have reason, let me dive into ... :-) Maybe I did something wrong...
Quoted 73 lines
Quoted 34 lines
Quoted 24 lines
include/configs/igep00x0.h +0
-0/* USB */ #define CONFIG_MUSB_UDC 1Quoted 22 lines
board/isee/igep00x0/igep00x0.h +3
-0@@ -39,6 +39,9 @@ const omap3_sysinfo sysinfo = {#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0030 ) "IGEP COM MODULE/ELECTRON",#endif +#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 ) + "IGEP COM PROTON", +#endif #if defined(CONFIG_ENV_IS_IN_ONENAND ) "ONENAND",#else boards.cfg +0
-0@@ -259,6 +259,7 @@ igep0020 arm armv7 igep00x0 isee igep0020_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENANDQuoted 9 lines
boards.cfg igep0020 arm armv7 igep00x0 isee
Quoted 6 lines
boards.cfg +1
-1igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND +igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND am3517_evm arm armv7 am3517evm logicpd omap3 mt_ventoux arm armv7 mt_ventoux teejet omap3 omap3_zoom1 arm armv7 zoom1 logicpd omap3 --This doesn't have a NAND version too like IGEP0020 and IGEP0030 boards?
Quoted 2 lines
No, the IGEP0032 only has OneNAND.
Perfect, I just asked since other IGEP boards used both flash memory types.
Quoted 16 lines
Quoted 16 lines
You said that this board has an on-board ethernet controller. Does this board use the
SMC911X chip connected to the OMAP GPMC too? In that case I guess you need something like this to haveCONFIG_CMD_NETenabled onboard/isee/igep00x0/igep00x0.c
for this board too:include/configs/igep00x0.h +0
-1@@ -118,7 +118,8 @@#ifdef CONFIG_BOOT_NAND #define CONFIG_CMD_NAND #endif -#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 )Quoted 9 lines
include/configs/igep00x0.h line 125
Quoted 6 lines
include/configs/igep00x0.h +2
-0+#if (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0020 ) || \ + (CONFIG_MACH_TYPE ==MACH_TYPE_IGEP0032 )#define CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */ #endif #define CONFIG_CMD_DHCP Right, I'll add this in version 2.
Great
Quoted 3 lines
Thanks and best regards,
EnricThanks a lot and best regards,
Javier