Skip to contentSkip to conversation

helper: Add architecture specific symbol prefix in the uboot list link script.

PATCH New Sonic Zhang 3 participants 3 messages Feb 6, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 helper: Add architecture specific symbol prefix in the uboot list link script.

From: Sonic Zhang <[email protected]>

Blackfin compiler add prefix '_' to each symbols. All symbols defined in the link script should have this prefix. Add it to the uboot list helper function make_u_boot_list.

---
 helper.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
helper.mk +2 -2
index 79a1da0..16e4cfd 100644
@@ -58,7 +58,7 @@ $(1): $(2)
 		-e ':s /^.\+$$$$/ { p;s/^\(.*\)\.[^\.]*$$$$/\1/;b s }' | \
 	sed -n -e 'h;s/$$$$/\a/p;g;s/$$$$/@/p;g;s/$$$$/~/p;' | \
 	LC_COLLATE=C sort -u | \
-	sed -n -e '/\a$$$$/ { s/\./_/g;s/\a$$$$/__start = .;/p; }'\
-		-e '/~$$$$/ { s/\./_/g;s/~$$$$/__end = .;/p; }'\
+	sed -n -e '/\a$$$$/ { s/\./_/g;s/\_u_boot_list/$(SYM_PREFIX)_u_boot_list/g;s/\a$$$$/__start = .;/p; }'\
+		-e '/~$$$$/ { s/\./_/g;s/\_u_boot_list/$(SYM_PREFIX)_u_boot_list/g;s/~$$$$/__end = .;/p; }'\
 		-e '/@$$$$/ { s/\(.*\)@$$$$/*(SORT(\1.*));/p }' > $(1)
 endef
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 helper: Add architecture specific symbol prefix in the uboot list link script.

Hi Sonic,

Quoted 16 lines · Sonic Zhang

From: Sonic Zhang <[email protected]>

Blackfin compiler add prefix '_' to each symbols. All symbols defined in the link script should have this prefix. Add it to the uboot list helper function make_u_boot_list.

---
 helper.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
helper.mk +0 -0
index 79a1da0..16e4cfd 100644

helper.mk $(1): $(2) · line 64

Quoted 9 lines
helper.mk +2 -2
@@ -58,7 +58,7 @@ $(1): $(2)
 		-e ':s /^.\+$$$$/ { p;s/^\(.*\)\.[^\.]*$$$$/\1/;b s }' | \
 	sed -n -e 'h;s/$$$$/\a/p;g;s/$$$$/@/p;g;s/$$$$/~/p;' | \
 	LC_COLLATE=C sort -u | \
-	sed -n -e '/\a$$$$/ { s/\./_/g;s/\a$$$$/__start = .;/p; }'\
-		-e '/~$$$$/ { s/\./_/g;s/~$$$$/__end = .;/p; }'\
+	sed -n -e '/\a$$$$/ { s/\./_/g;s/\_u_boot_list/$(SYM_PREFIX)_u_boot_list/g;s/\a$$$$/__start = .;/p; }'\
+		-e '/~$$$$/ { s/\./_/g;s/\_u_boot_list/$(SYM_PREFIX)_u_boot_list/g;s/~$$$$/__end = .;/p; }'\
 		-e '/@$$$$/ { s/\(.*\)@$$$$/*(SORT(\1.*));/p }' > $(1)
 endef

The patch I submitted to fix relocation of linker lists [1] removes file helper.mk. There is thus no need to change it.

[1] http://patchwork.ozlabs.org/patch/217695/

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH 1/1 helper: Add architecture specific symbol prefix in the uboot list link script.

In reply to Sonic Zhang

Dear Sonic Zhang,

Quoted 7 lines · In message <[email protected]> you wrote:

From: Sonic Zhang <[email protected]>

Blackfin compiler add prefix '_' to each symbols. All symbols defined in the link script should have this prefix. Add it to the uboot list helper function make_u_boot_list.

Maybe the BF compiler does so - but this script is used by all
architectures: did you verify that this change is actually working on those?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Nobody will ever need more than 640k RAM!" -- Bill Gates, 1981
"Windows 95 needs at least 8 MB RAM." -- Bill Gates, 1996
"Nobody will ever need Windows 95." -- logical conclusion