Skip to contentSkip to conversation

ARM: mxs: mm: Fix sparse warning

PATCH New Fabio Estevam 2 participants 4 messages Feb 11, 2013 – Feb 17, 2013

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 ARM: mxs: mm: Fix sparse warning

From: Fabio Estevam <[email protected]>

Include <mach/common.h> header to fix the following sparse warnings:

arch/arm/mach-mxs/mm.c:43:13: warning: symbol 'mx23_map_io' was not declared. Should it be static? arch/arm/mach-mxs/mm.c:48:13: warning: symbol 'mx28_map_io' was not declared. Should it be static?

---
 arch/arm/mach-mxs/mm.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-mxs/mm.c +1 -0
index a4294aa..e63b7d8 100644
@@ -18,6 +18,7 @@
 
 #include <mach/mx23.h>
 #include <mach/mx28.h>
+#include <mach/common.h>
 
 /*
  * Define the MX23 memory map.
Signature · 1 line
1.7.9.5
author reviewer
#1 lore raw

PATCH 2/3 ARM: mxs: icoll: Fix sparse warning

From: Fabio Estevam <[email protected]>

Fix the following sparse warning:

arch/arm/mach-mxs/icoll.c:103:13: warning: symbol 'icoll_of_init' was not declared. Should it be static?

---
 arch/arm/mach-mxs/icoll.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-mxs/icoll.c +1 -1
index 8fb23af..e26eeba 100644
@@ -100,7 +100,7 @@ static struct irq_domain_ops icoll_irq_domain_ops = {
 	.xlate = irq_domain_xlate_onecell,
 };
 
-void __init icoll_of_init(struct device_node *np,
+static void __init icoll_of_init(struct device_node *np,
 			  struct device_node *interrupt_parent)
 {
 	/*
Signature · 1 line
1.7.9.5
author reviewer
#2 lore raw

PATCH 3/3 ARM: mxs: ocotp: Fix sparse warning

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Include <mach/common.h> header to fix the following sparse warning:

arch/arm/mach-mxs/ocotp.c:33:11: warning: symbol 'mxs_get_ocotp' was not declared. Should it be static?

---
 arch/arm/mach-mxs/ocotp.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-mxs/ocotp.c +1 -0
index 54add60..1dff467 100644
@@ -19,6 +19,7 @@
 #include <asm/processor.h>	/* for cpu_relax() */
 
 #include <mach/mxs.h>
+#include <mach/common.h>
 
 #define OCOTP_WORD_OFFSET		0x20
 #define OCOTP_WORD_COUNT		0x20
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH 1/3 ARM: mxs: mm: Fix sparse warning

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Include <mach/common.h> header to fix the following sparse warnings:

arch/arm/mach-mxs/mm.c:43:13: warning: symbol 'mx23_map_io' was not declared. Should it be static? arch/arm/mach-mxs/mm.c:48:13: warning: symbol 'mx28_map_io' was not declared. Should it be static?

Queued all 3 for 3.10, as I do not categorize them as critical fixes.

Shawn

Quoted 19 lines
---
 arch/arm/mach-mxs/mm.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-mxs/mm.c +1 -0
index a4294aa..e63b7d8 100644
@@ -18,6 +18,7 @@
 
 #include <mach/mx23.h>
 #include <mach/mx28.h>
+#include <mach/common.h>
 
 /*
  * Define the MX23 memory map.
Signature · 1 line
1.7.9.5