sound: rme32.c irq enabling after spin_lock_irq
PATCH 1/1 sound: rme32.c irq enabling after spin_lock_irq
According to the other code in this driver and similar code in rme96 it seems, that spin_lock_irq in snd_rme32_capture_close function should be paired with spin_unlock_irq.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by Denis Efremov <[email protected]>
--- sound/pci/rme32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/rme32.c +1 -1
@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)spin_lock_irq (&rme32->lock); rme32->capture_substream =NULL ; rme32->capture_periodsize =0 ; -spin_unlock (&rme32->lock); +spin_unlock_irq (&rme32->lock);return 0 ; }
Signature · 1 line
1.8.1.2
Takashi Iwai
AppliedAt Mon, 11 Feb 2013 19:04:06 +0400,
Quoted 9 lines · Denis Efremov
According to the other code in this driver and similar code in rme96 it seems, that
spin_lock_irqinsnd_rme32_capture_closefunction should be paired withspin_unlock_irq.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by Denis Efremov <[email protected]>
Thanks, applied (with Cc to stable, too).
Takashi
Quoted 20 lines
--- sound/pci/rme32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/pci/rme32.c +1
-1@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)spin_lock_irq (&rme32->lock); rme32->capture_substream =NULL ; rme32->capture_periodsize =0 ; -spin_unlock (&rme32->lock); +spin_unlock_irq (&rme32->lock);return 0 ; }Signature · 1 line
1.8.1.2