ALSA: ali5451: remove irq enabling in pointer callback
PATCH 1/1 ALSA: ali5451: remove irq enabling in pointer callback
snd_ali_pointer function is called with local interrupts disabled. However it seems very strange to reenable them in such way.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by Denis Efremov <[email protected]>
--- sound/pci/ali5451/ali5451.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/ali5451/ali5451.c +1 -1
@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)spin_lock (&codec->reg_lock);if (!pvoice->running) { -spin_unlock_irq (&codec->reg_lock); +spin_unlock (&codec->reg_lock);return 0 ; }outb (pvoice->number,ALI_REG (codec,ALI_GC_CIR ));
Signature · 1 line
1.8.1.2
Takashi Iwai
AppliedAt Mon, 11 Feb 2013 19:49:48 +0400,
Quoted 8 lines · Denis Efremov
snd_ali_pointerfunction is called with local interrupts disabled. However it seems very strange to reenable them in such way.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by Denis Efremov <[email protected]>
Thanks, applied now.
Takashi
Quoted 20 lines
--- sound/pci/ali5451/ali5451.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/pci/ali5451/ali5451.c +1
-1@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)spin_lock (&codec->reg_lock);if (!pvoice->running) { -spin_unlock_irq (&codec->reg_lock); +spin_unlock (&codec->reg_lock);return 0 ; }outb (pvoice->number,ALI_REG (codec,ALI_GC_CIR ));Signature · 1 line
1.8.1.2