Skip to contentSkip to conversation

mfd: syscon: Fix sparse warning

PATCH Applied Fabio Estevam 2 participants 4 messages Feb 11, 2013 – Feb 12, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mfd: syscon: Fix sparse warning

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/mfd/syscon.c:40:15: warning: symbol 'syscon_node_to_regmap' was not declared. Should it be static? drivers/mfd/syscon.c:56:15: warning: symbol 'syscon_regmap_lookup_by_compatible' was not declared. Should it be static? drivers/mfd/syscon.c:72:15: warning: symbol 'syscon_regmap_lookup_by_phandle' was not declared. Should it be static?

---
 drivers/mfd/syscon.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/syscon.c +1 -0
index 3f10591..61aea63 100644
@@ -20,6 +20,7 @@
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
+#include <linux/mfd/syscon.h>
 
 static struct platform_driver syscon_driver;
 
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 2/2 mfd: da9052-i2c: Staticize da9052_i2c_fix()

From: Fabio Estevam <[email protected]>

da9052_i2c_fix() is only used locally, so let it be static.

Fix the following sparse warning:

drivers/mfd/da9052-i2c.c:63:5: warning: symbol 'da9052_i2c_fix' was not declared. Should it be static?

---
 drivers/mfd/da9052-i2c.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mfd/da9052-i2c.c +1 -2
index 885e567..6a9fec4 100644
@@ -60,7 +60,7 @@ static inline bool i2c_safe_reg(unsigned char reg)
  * This fix is to follow any read or write with a dummy read to a safe
  * register.
  */
-int da9052_i2c_fix(struct da9052 *da9052, unsigned char reg)
+static int da9052_i2c_fix(struct da9052 *da9052, unsigned char reg)
 {
 	int val;
 
@@ -85,7 +85,6 @@ int da9052_i2c_fix(struct da9052 *da9052, unsigned char reg)
 
 	return 0;
 }
-EXPORT_SYMBOL(da9052_i2c_fix);
 
 static int da9052_i2c_enable_multiwrite(struct da9052 *da9052)
 {
Signature · 1 line
1.7.9.5
Applied
#3 lore raw
In reply to Fabio Estevam

Hi Fabio,

Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/mfd/syscon.c:40:15: warning: symbol 'syscon_node_to_regmap' was not declared. Should it be static? drivers/mfd/syscon.c:56:15: warning: symbol 'syscon_regmap_lookup_by_compatible' was not declared. Should it be static? drivers/mfd/syscon.c:72:15: warning: symbol 'syscon_regmap_lookup_by_phandle' was not declared. Should it be static?

Quoted 5 lines
---
 drivers/mfd/syscon.c |    1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
Applied
#2 lore raw

Re: [PATCH 2/2] mfd: da9052-i2c: Staticize da9052_i2c_fix()

In reply to Fabio Estevam

Hi Fabio,

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

da9052_i2c_fix() is only used locally, so let it be static.

Fix the following sparse warning:

Quoted 7 lines

drivers/mfd/da9052-i2c.c:63:5: warning: symbol 'da9052_i2c_fix' was not declared. Should it be static?

---
 drivers/mfd/da9052-i2c.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Applied as well, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/