Skip to contentSkip to conversation

i2c: tegra: remove warning dump if timeout happen in transfer

PATCH New Laxman Dewangan 1 participant 1 message Feb 14, 2013

Subsystems (3)
lore
Share & tools
lore

Laxman Dewangan

author maintainer
#0 lore raw

PATCH 1/1 i2c: tegra: remove warning dump if timeout happen in transfer

If timeout error occurs in the i2c transfer then it was dumping warning of call stack.

Remove the warning dump as there is may be possibility that some slave devices are busy and not responding the i2c communication.

---
The patch is generated based on discussion happen between Stephena and Wolfram on the patch:
i2c: add bcm2835 driver

 drivers/i2c/busses/i2c-tegra.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-tegra.c +1 -1
index ae2e027..36704e3 100644
@@ -587,7 +587,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
 	ret = wait_for_completion_timeout(&i2c_dev->msg_complete, TEGRA_I2C_TIMEOUT);
 	tegra_i2c_mask_irq(i2c_dev, int_mask);
 
-	if (WARN_ON(ret == 0)) {
+	if (ret == 0) {
 		dev_err(i2c_dev->dev, "i2c transfer timed out\n");
 
 		tegra_i2c_init(i2c_dev);
Signature · 1 line
1.7.1.1