regulator: palmas: Change the DT node property names to follow the convention
Subsystems (2)
PATCH 4/4 regulator: palmas: Change the DT node property names to follow the convention
DT node properties should not have "_". Replacing them by "-".
--- drivers/regulator/palmas-regulator.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/regulator/palmas-regulator.c +4 -4
@@ -551,17 +551,17 @@ static void palmas_dt_to_pdata(struct device *dev, sizeof(struct palmas_reg_init), GFP_KERNEL); ret =of_property_read_u32 (palmas_matches[idx].of_node, -"ti,warm_reset" , &prop); +"ti,warm-reset" , &prop);if (!ret) pdata->reg_init[idx]->warm_reset = prop; ret =of_property_read_u32 (palmas_matches[idx].of_node, -"ti,roof_floor" , &prop); +"ti,roof-floor" , &prop);if (!ret) pdata->reg_init[idx]->roof_floor = prop; ret =of_property_read_u32 (palmas_matches[idx].of_node, -"ti,mode_sleep" , &prop); +"ti,mode-sleep" , &prop);if (!ret) pdata->reg_init[idx]->mode_sleep = prop;
@@ -576,7 +576,7 @@ static void palmas_dt_to_pdata(struct device *dev, pdata->reg_init[idx]->vsel = prop; } - ret =of_property_read_u32 (node,"ti,ldo6_vibrator" , &prop); + ret =of_property_read_u32 (node,"ti,ldo6-vibrator" , &prop);if (!ret) pdata->ldo6_vibrator = prop; }
Signature · 1 line
1.7.5.4
Quoted 3 lines · J Keerthy
DT node properties should not have "_". Replacing them by "-".
Signed-off-by J Keerthy <[email protected]>
This must need an update to the binding document too, and probably any DT files that ended up getting merged for it?
Hi Mark,
Quoted 9 lines
-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Tuesday, February 19, 2013 6:12 PM
To: J, KEERTHY
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention
Quoted 7 lines
Quoted 3 lines · J Keerthy
DT node properties should not have "_". Replacing them by "-".
Signed-off-by J Keerthy <[email protected]>This must need an update to the binding document too, and probably any DT files that ended up getting merged for it?
I have sent a patch with the document update. That is the first patch in The series.
Regards,
Keerthy
Quoted 5 lines · KEERTHY
Quoted 2 lines
This must need an update to the binding document too, and probably any DT files that ended up getting merged for it?
I have sent a patch with the document update. That is the first patch in The series.
You sent the patches as unthreaded mails and didn't CC me on the first patch so I've not actually seen the documentation. Incremental updates like this really ought to be done as part of a single patch anyway, there's no point in splitting things up and as we've just seen it can make it harder to review.
Hi Mark,
Quoted 14 lines
-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Wednesday, February 20, 2013 1:43 AM
To: J, KEERTHY
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the conventionQuoted 2 lines · KEERTHY
Quoted 2 lines
This must need an update to the binding document too, and probably any DT files that ended up getting merged for it?
Quoted 8 lines
Quoted 2 lines
I have sent a patch with the document update. That is the first patch in The series.
You sent the patches as unthreaded mails and didn't CC me on the first patch so I've not actually seen the documentation. Incremental updates like this really ought to be done as part of a single patch anyway, there's no point in splitting things up and as we've just seen it can make it harder to review.
Extremely sorry about that. I am resending the Patch 1.
Regards,
Keerthy
Mark Brown
AppliedQuoted 1 line · J Keerthy
DT node properties should not have "_". Replacing them by "-".
Applied, thanks.
Quoted 11 lines
-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Friday, March 01, 2013 1:16 PM
To: J, KEERTHY
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 4/4] regulator: palmas: Change the DT node property names to follow the convention
Quoted 4 lines
Quoted 1 line · J Keerthy
DT node properties should not have "_". Replacing them by "-".
Applied, thanks.
Thanks Mark.