mmc: dw_mmc: Add MSHC compatible for Exynos4412

PATCH Superseded Dongjin Kim 5 participants 11 messages Feb 18, 2013 – Mar 22, 2013

Subsystems (3)

Arm Samsung Exynos MMC, SD and SDIO Synopsys DesignWare MMC/SD/SDIO driver

lore

Share & tools

lore

Dongjin Kim

author

2013-02-18 18:06 UTC #0 lore raw

PATCH v3 1/1 mmc: dw_mmc: Add MSHC compatible for Exynos4412

This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.

Cc Jaehoon Chung <[email protected]>

Cc Sachin Kamat <[email protected]>

Signed-off-by Dongjin Kim <[email protected]>

---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

drivers/mmc/host/dw_mmc-exynos.c +7 -5

index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
 	return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
 	MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
 		MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
 	MMC_CAP_CMD23,

@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
 	MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-	.caps			= exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+	.caps			= exynos_dwmmc_caps,
 	.init			= dw_mci_exynos_priv_init,
 	.setup_clock		= dw_mci_exynos_setup_clock,
 	.prepare_command	= dw_mci_exynos_prepare_command,

@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+	{ .compatible = "samsung,exynos4412-dw-mshc",
+			.data = &exynos_drv_data, },
 	{ .compatible = "samsung,exynos5250-dw-mshc",
-			.data = &exynos5250_drv_data, },
+			.data = &exynos_drv_data, },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);

Signature · 1 line

1.7.10.4

Arnd Bergmann

2013-02-18 22:36 UTC #1 lore raw

Quoted 9 lines · Dongjin Kim

This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.
Cc Jaehoon Chung <[email protected]>
Cc Sachin Kamat <[email protected]>
Signed-off-by Dongjin Kim <[email protected]>

If they are completely compatibly, you can just list "samsung,exynos4412-dw-mshc" in the compatible property of the exynos5250 device tree, along with the other ones like:

	compatible = "samsung,exynos5250-dw-mshc", "samsung,exynos4412-dw-mshc", "snps,dw-mshc";

then you don't need to change the driver at all.

Arnd

Seungwon Jeon

2013-02-19 10:19 UTC #2 lore raw

In reply to Dongjin Kim

Quoted 4 lines · Dongjin Kim

This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.

It's not actually same.
Exynos4412 doesn't have forward compatibilities for Exynos5250. I agree that functionality of exynos_drv_data is common. These functions have been implemented for existing Exynos*. But in case of caps, it can't applied completely.
I'm concerning about this.

Thanks,
Seungwon Jeon

Quoted 53 lines

Cc Jaehoon Chung <[email protected]>

Cc Sachin Kamat <[email protected]>

Signed-off-by Dongjin Kim <[email protected]>

---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

drivers/mmc/host/dw_mmc-exynos.c +7 -6

index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
 	return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
 	MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
 		MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
 	MMC_CAP_CMD23,

@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
 	MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-	.caps			= exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+	.caps			= exynos_dwmmc_caps,
 	.init			= dw_mci_exynos_priv_init,
 	.setup_clock		= dw_mci_exynos_setup_clock,
 	.prepare_command	= dw_mci_exynos_prepare_command,

@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+	{ .compatible = "samsung,exynos4412-dw-mshc",
+			.data = &exynos_drv_data, },
 	{ .compatible = "samsung,exynos5250-dw-mshc",
-			.data = &exynos5250_drv_data, },
+			.data = &exynos_drv_data, },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--

1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Dongjin Kim

author

2013-02-19 12:34 UTC #3 lore raw

Hello Seungwon,

Thank you for reviewing and I understand what you mean.

I agree that Exynos5250 and Exynos4412 are not same, no idea how much they are different because no Exynos5250 spec on my hand. But at least I assumed that the capabilities below are supported by Exynos4412 in terms of its datasheet and it does work on my end as expected. :) Also I assumed it will be separated if one of both become different to add more capabilities.

        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,

Maybe my understanding or approach is wrong since I do not have the information of Exynos5250.
And suggestion do you have?

Regards,
Dongjin.

Quoted 69 lines · Seungwon Jeon

Quoted 4 lines · Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.
It's not actually same.
Exynos4412 doesn't have forward compatibilities for Exynos5250. I agree that functionality of exynos_drv_data is common. These functions have been implemented for existing Exynos*. But in case of caps, it can't applied completely.
I'm concerning about this.
Thanks,
Seungwon Jeon
Quoted 53 lines
Cc Jaehoon Chung <[email protected]>
Cc Sachin Kamat <[email protected]>
Signed-off-by Dongjin Kim <[email protected]>
---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/mmc/host/dw_mmc-exynos.c +7 -6
index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
      return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
      MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
              MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
      MMC_CAP_CMD23,
@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
      MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-     .caps                   = exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+     .caps                   = exynos_dwmmc_caps,
      .init                   = dw_mci_exynos_priv_init,
      .setup_clock            = dw_mci_exynos_setup_clock,
      .prepare_command        = dw_mci_exynos_prepare_command,
@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+     { .compatible = "samsung,exynos4412-dw-mshc",
+                     .data = &exynos_drv_data, },
      { .compatible = "samsung,exynos5250-dw-mshc",
-                     .data = &exynos5250_drv_data, },
+                     .data = &exynos_drv_data, },
      {},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Alim Akhtar

2013-02-19 16:40 UTC #4 lore raw

Hi,

Quoted 11 lines · Dongjin Kim

Hello Seungwon,
Thank you for reviewing and I understand what you mean.
I agree that Exynos5250 and Exynos4412 are not same, no idea how much they are different because no Exynos5250 spec on my hand. But at least I assumed that the capabilities below are supported by Exynos4412 in terms of its datasheet and it does work on my end as expected. :) Also I assumed it will be separated if one of both become different to add more capabilities.

Quoted 6 lines

        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
Maybe my understanding or approach is wrong since I do not have the information of Exynos5250.
And suggestion do you have?

Recently Guennadi Liakhovetski has done some work to centralize the mmc capabilities. See [1] and [2].
Those patches are pushed to Chris's mmc-next tree.
Is it possible to extend [1] and [2] and add more capabilities (at least all known one) and let these caps being passed from DT instead?

Second thought is, let the common minimum caps as a part of .caps field in dw_mmc-exynos.c itself and pass the extra/advance controller caps from DT and parse them via dw_mci_parse_dt() in dw_mmc.c itself.

[1] https://patchwork.kernel.org/patch/1991851/
[2] https://patchwork.kernel.org/patch/2106531/

Quoted 77 lines

Regards,
Dongjin.
Quoted 64 lines · Seungwon Jeon
Quoted 4 lines · Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.
It's not actually same.
Exynos4412 doesn't have forward compatibilities for Exynos5250. I agree that functionality of exynos_drv_data is common. These functions have been implemented for existing Exynos*. But in case of caps, it can't applied completely.
I'm concerning about this.
Thanks,
Seungwon Jeon
Quoted 49 lines
Cc Jaehoon Chung <[email protected]>
Cc Sachin Kamat <[email protected]>
Signed-off-by Dongjin Kim <[email protected]>
---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/mmc/host/dw_mmc-exynos.c +7 -6
index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
      return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
      MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
              MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
      MMC_CAP_CMD23,
@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
      MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-     .caps                   = exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+     .caps                   = exynos_dwmmc_caps,
      .init                   = dw_mci_exynos_priv_init,
      .setup_clock            = dw_mci_exynos_setup_clock,
      .prepare_command        = dw_mci_exynos_prepare_command,
@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+     { .compatible = "samsung,exynos4412-dw-mshc",
+                     .data = &exynos_drv_data, },
      { .compatible = "samsung,exynos5250-dw-mshc",
-                     .data = &exynos5250_drv_data, },
+                     .data = &exynos_drv_data, },
      {},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--
1.7.10.4
Quoted 5 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines

Regards,
Alim

Seungwon Jeon

2013-02-21 10:53 UTC #5 lore raw

Quoted 20 lines · Alim Akhtar

Hi,
Quoted 17 lines · Dongjin Kim
Hello Seungwon,
Thank you for reviewing and I understand what you mean.
I agree that Exynos5250 and Exynos4412 are not same, no idea how much they are different because no Exynos5250 spec on my hand. But at least I assumed that the capabilities below are supported by Exynos4412 in terms of its datasheet and it does work on my end as expected. :) Also I assumed it will be separated if one of both become different to add more capabilities.
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
Maybe my understanding or approach is wrong since I do not have the information of Exynos5250.
And suggestion do you have?

At least, these capabilities can be shared because of common feature, not fully same. Dongjin, could you modify the commit message and comments of code?

Let me introduce the functional feature of Exynos5250 and capability extension. I guess I'll send soon.

Thanks,
Seungwon Jeon

Quoted 99 lines

Recently Guennadi Liakhovetski has done some work to centralize the mmc capabilities. See [1] and [2].
Those patches are pushed to Chris's mmc-next tree.
Is it possible to extend [1] and [2] and add more capabilities (at least all known one) and let these caps being passed from DT instead?
Second thought is, let the common minimum caps as a part of .caps field in dw_mmc-exynos.c itself and pass the extra/advance controller caps from DT and parse them via dw_mci_parse_dt() in dw_mmc.c itself.
[1] https://patchwork.kernel.org/patch/1991851/
[2] https://patchwork.kernel.org/patch/2106531/
Quoted 73 lines
Regards,
Dongjin.
Quoted 64 lines · Seungwon Jeon
Quoted 4 lines · Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.
It's not actually same.
Exynos4412 doesn't have forward compatibilities for Exynos5250. I agree that functionality of exynos_drv_data is common. These functions have been implemented for existing Exynos*. But in case of caps, it can't applied completely.
I'm concerning about this.
Thanks,
Seungwon Jeon
Quoted 49 lines
Cc Jaehoon Chung <[email protected]>
Cc Sachin Kamat <[email protected]>
Signed-off-by Dongjin Kim <[email protected]>
---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/mmc/host/dw_mmc-exynos.c +7 -6
index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
      return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
      MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
              MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
      MMC_CAP_CMD23,
@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
      MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-     .caps                   = exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+     .caps                   = exynos_dwmmc_caps,
      .init                   = dw_mci_exynos_priv_init,
      .setup_clock            = dw_mci_exynos_setup_clock,
      .prepare_command        = dw_mci_exynos_prepare_command,
@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+     { .compatible = "samsung,exynos4412-dw-mshc",
+                     .data = &exynos_drv_data, },
      { .compatible = "samsung,exynos5250-dw-mshc",
-                     .data = &exynos5250_drv_data, },
+                     .data = &exynos_drv_data, },
      {},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--
1.7.10.4
Quoted 5 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Dongjin Kim

author

2013-02-22 01:39 UTC #6 lore raw

Hello Seungwon,

OK, I will change the commit message. And I also think Alim's idea is good but need more detail about functional features of Synopsis' IP. Similar situation would be happened to Exynos4210 which is not supported by dw_mmc-exynos.c yet.

Regards,
Dongjin.

Quoted 130 lines · Seungwon Jeon

Quoted 20 lines · Alim Akhtar
Hi,
Quoted 17 lines · Dongjin Kim
Hello Seungwon,
Thank you for reviewing and I understand what you mean.
I agree that Exynos5250 and Exynos4412 are not same, no idea how much they are different because no Exynos5250 spec on my hand. But at least I assumed that the capabilities below are supported by Exynos4412 in terms of its datasheet and it does work on my end as expected. :) Also I assumed it will be separated if one of both become different to add more capabilities.
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
Maybe my understanding or approach is wrong since I do not have the information of Exynos5250.
And suggestion do you have?
At least, these capabilities can be shared because of common feature, not fully same. Dongjin, could you modify the commit message and comments of code?
Let me introduce the functional feature of Exynos5250 and capability extension. I guess I'll send soon.
Thanks,
Seungwon Jeon
Quoted 99 lines
Recently Guennadi Liakhovetski has done some work to centralize the mmc capabilities. See [1] and [2].
Those patches are pushed to Chris's mmc-next tree.
Is it possible to extend [1] and [2] and add more capabilities (at least all known one) and let these caps being passed from DT instead?
Second thought is, let the common minimum caps as a part of .caps field in dw_mmc-exynos.c itself and pass the extra/advance controller caps from DT and parse them via dw_mci_parse_dt() in dw_mmc.c itself.
[1] https://patchwork.kernel.org/patch/1991851/
[2] https://patchwork.kernel.org/patch/2106531/
Quoted 73 lines
Regards,
Dongjin.
Quoted 64 lines · Seungwon Jeon
Quoted 4 lines · Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.
It's not actually same.
Exynos4412 doesn't have forward compatibilities for Exynos5250. I agree that functionality of exynos_drv_data is common. These functions have been implemented for existing Exynos*. But in case of caps, it can't applied completely.
I'm concerning about this.
Thanks,
Seungwon Jeon
Quoted 49 lines
Cc Jaehoon Chung <[email protected]>
Cc Sachin Kamat <[email protected]>
Signed-off-by Dongjin Kim <[email protected]>
---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/mmc/host/dw_mmc-exynos.c +7 -6
index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
      return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
      MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
              MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
      MMC_CAP_CMD23,
@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
      MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-     .caps                   = exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+     .caps                   = exynos_dwmmc_caps,
      .init                   = dw_mci_exynos_priv_init,
      .setup_clock            = dw_mci_exynos_setup_clock,
      .prepare_command        = dw_mci_exynos_prepare_command,
@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+     { .compatible = "samsung,exynos4412-dw-mshc",
+                     .data = &exynos_drv_data, },
      { .compatible = "samsung,exynos5250-dw-mshc",
-                     .data = &exynos5250_drv_data, },
+                     .data = &exynos_drv_data, },
      {},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--
1.7.10.4
Quoted 5 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Seungwon Jeon

2013-02-22 11:16 UTC #7 lore raw

Quoted 4 lines · Dongjin Kim

Hello Seungwon,
OK, I will change the commit message. And I also think Alim's idea is good but need more detail about functional features of Synopsis' IP.

Yes, Alim gave good suggestions.
It would be useful. But I think it's close to platform rather than Synopsys itself. I'm starting to compare the new generic parsing with dw_mmc.

Quoted 2 lines

Similar situation would be happened to Exynos4210 which is not supported by dw_mmc-exynos.c yet.

Maybe not, it should be done.

Thanks,
Seungwon Jeon

Quoted 139 lines

Regards,
Dongjin.
Quoted 21 lines · Seungwon Jeon
Quoted 20 lines · Alim Akhtar
Hi,
Quoted 17 lines · Dongjin Kim
Hello Seungwon,
Thank you for reviewing and I understand what you mean.
I agree that Exynos5250 and Exynos4412 are not same, no idea how much they are different because no Exynos5250 spec on my hand. But at least I assumed that the capabilities below are supported by Exynos4412 in terms of its datasheet and it does work on my end as expected. :) Also I assumed it will be separated if one of both become different to add more capabilities.
        MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
               MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
Maybe my understanding or approach is wrong since I do not have the information of Exynos5250.
And suggestion do you have?
Quoted 109 lines
At least, these capabilities can be shared because of common feature, not fully same. Dongjin, could you modify the commit message and comments of code?
Let me introduce the functional feature of Exynos5250 and capability extension. I guess I'll send soon.
Thanks,
Seungwon Jeon
Quoted 99 lines
Recently Guennadi Liakhovetski has done some work to centralize the mmc capabilities. See [1] and [2].
Those patches are pushed to Chris's mmc-next tree.
Is it possible to extend [1] and [2] and add more capabilities (at least all known one) and let these caps being passed from DT instead?
Second thought is, let the common minimum caps as a part of .caps field in dw_mmc-exynos.c itself and pass the extra/advance controller caps from DT and parse them via dw_mci_parse_dt() in dw_mmc.c itself.
[1] https://patchwork.kernel.org/patch/1991851/
[2] https://patchwork.kernel.org/patch/2106531/
Quoted 73 lines
Regards,
Dongjin.
Quoted 64 lines · Seungwon Jeon
Quoted 4 lines · Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name.
It's not actually same.
Exynos4412 doesn't have forward compatibilities for Exynos5250. I agree that functionality of exynos_drv_data is common. These functions have been implemented for existing Exynos*. But in case of caps, it can't applied completely.
I'm concerning about this.
Thanks,
Seungwon Jeon
Quoted 49 lines
Cc Jaehoon Chung <[email protected]>
Cc Sachin Kamat <[email protected]>
Signed-off-by Dongjin Kim <[email protected]>
---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/mmc/host/dw_mmc-exynos.c +7 -6
index 4d50da6..38cd03c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
      return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos_dwmmc_caps[4] = {
      MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
              MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
      MMC_CAP_CMD23,
@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
      MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-     .caps                   = exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+     .caps                   = exynos_dwmmc_caps,
      .init                   = dw_mci_exynos_priv_init,
      .setup_clock            = dw_mci_exynos_setup_clock,
      .prepare_command        = dw_mci_exynos_prepare_command,
@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+     { .compatible = "samsung,exynos4412-dw-mshc",
+                     .data = &exynos_drv_data, },
      { .compatible = "samsung,exynos5250-dw-mshc",
-                     .data = &exynos5250_drv_data, },
+                     .data = &exynos_drv_data, },
      {},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--
1.7.10.4
Quoted 5 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Dongjin Kim

author

2013-02-22 15:18 UTC #8 lore raw

PATCH v4 1/1 mmc: dw_mmc: Add MSHC compatible for Exynos4412

In reply to Dongjin Kim

This patch adds the compatible string for MSHC controller of Exynos4412. And exynos5250_dwmmc_caps is renamed to exynos_dwmmc_caps, since it has the capablities of common feature supported by Exynos4 and Exynos5.

Cc Seungwon Jeon <[email protected]>

Cc Jaehoon Chung <[email protected]>

Cc Sachin Kamat <[email protected]>

Signed-off-by Dongjin Kim <[email protected]>

---
 drivers/mmc/host/dw_mmc-exynos.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

drivers/mmc/host/dw_mmc-exynos.c +7 -5

index 4d50da6..dd8f58c 100644
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
 	return 0;
 }
 
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Common capabilities of Exynos4/Exynos5 SoC */
+static unsigned long exynos_dwmmc_caps[4] = {
 	MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
 		MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
 	MMC_CAP_CMD23,

@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
 	MMC_CAP_CMD23,
 };
 
-static const struct dw_mci_drv_data exynos5250_drv_data = {
-	.caps			= exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos_drv_data = {
+	.caps			= exynos_dwmmc_caps,
 	.init			= dw_mci_exynos_priv_init,
 	.setup_clock		= dw_mci_exynos_setup_clock,
 	.prepare_command	= dw_mci_exynos_prepare_command,

@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
 };
 
 static const struct of_device_id dw_mci_exynos_match[] = {
+	{ .compatible = "samsung,exynos4412-dw-mshc",
+			.data = &exynos_drv_data, },
 	{ .compatible = "samsung,exynos5250-dw-mshc",
-			.data = &exynos5250_drv_data, },
+			.data = &exynos_drv_data, },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);

Signature · 1 line

1.7.10.4

Seungwon Jeon

Acked-by on v4 1/1

2013-03-13 14:17 UTC #9 lore raw

Quoted 5 lines · Dongjin Kim

This patch adds the compatible string for MSHC controller of Exynos4412. And exynos5250_dwmmc_caps is renamed to exynos_dwmmc_caps, since it has the capablities of common feature supported by Exynos4 and Exynos5.
Cc Seungwon Jeon <[email protected]>

Acked-by Seungwon Jeon <[email protected]>

Chris Ball

2013-03-22 16:56 UTC #10 lore raw

Hi,

Quoted 8 lines · Seungwon Jeon

Quoted 5 lines · Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412. And exynos5250_dwmmc_caps is renamed to exynos_dwmmc_caps, since it has the capablities of common feature supported by Exynos4 and Exynos5.
Cc Seungwon Jeon <[email protected]>
Acked-by Seungwon Jeon <[email protected]>

Thanks, pushed to mmc-next for 3.10.

- Chris.

Signature · 2 lines

Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child