Skip to contentSkip to conversation

kernel/fork.c: Simplifying a snippet of code.

PATCH In review Raphael S.Carvalho 2 participants 2 messages Feb 20, 2013

Subsystems (3)
lore
Share & tools
lore
#1 lore raw
In reply to Raphael S.Carvalho
Quoted 3 lines · Raphael S.Carvalho

Just sending this patch in order to simplify the code. However, I'm not sure if the code was written in that way due to specific reasons.

That doesn't look any simpler to me, and I expect you have now biased the branch in the wrong direction.

The CLONE_THREAD is not the common case.

Eric

Quoted 20 lines
---
 kernel/fork.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
kernel/fork.c +1 -3
index c535f33..237204d 100644
@@ -1341,9 +1341,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 	}
 
 	p->pid = pid_nr(pid);
-	p->tgid = p->pid;
-	if (clone_flags & CLONE_THREAD)
-		p->tgid = current->tgid;
+	p->tgid = (clone_flags & CLONE_THREAD) ? current->tgid : p->pid;
 
 	p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL;
 	/*
#0 lore raw

PATCH 1/1 kernel/fork.c: Simplifying a snippet of code.

Just sending this patch in order to simplify the code.
However, I'm not sure if the code was written in that way due to specific reasons.

---
 kernel/fork.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
kernel/fork.c +1 -3
index c535f33..237204d 100644
@@ -1341,9 +1341,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 	}
 
 	p->pid = pid_nr(pid);
-	p->tgid = p->pid;
-	if (clone_flags & CLONE_THREAD)
-		p->tgid = current->tgid;
+	p->tgid = (clone_flags & CLONE_THREAD) ? current->tgid : p->pid;
 
 	p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL;
 	/*
Signature · 1 line
1.7.2.5