Skip to contentSkip to conversation

ppc: fixed RAM initialization bug in hw/ppc4xx_devs.c, can now use memory larger than 256MB in bamboo PPC machines

PATCH Applied Alin Tomescu 2 participants 2 messages Feb 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc: fixed RAM initialization bug in hw/ppc4xx_devs.c, can now use memory larger than 256MB in bamboo PPC machines

I hope this is the right way of submitting QEMU patches.

I was trying to launch a PowerPC "bamboo" machine with more than 256MB of RAM with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but QEMU would just hang. However, when I used -m 256, the machine would boot.

I looked through the code in hw/ and it seems there is an error when the RAM memory is setup (if my understanding is correct).

After patching it, the machine launched and booted successfully with 512MB of RAM.

---
 hw/ppc4xx_devs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/ppc4xx_devs.c +1 -1
index 5e491bc..b6bb0e1 100644
@@ -700,7 +700,7 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks,
                 vmstate_register_ram_global(&ram_memories[i]);
                 ram_bases[i] = base;
                 ram_sizes[i] = bank_size;
-                base += ram_size;
+                base += bank_size;
                 size_left -= bank_size;
                 break;
             }
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 9 lines · Alin Tomescu

I hope this is the right way of submitting QEMU patches.

I was trying to launch a PowerPC "bamboo" machine with more than 256MB of RAM with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but QEMU would just hang. However, when I used -m 256, the machine would boot.

I looked through the code in hw/ and it seems there is an error when the RAM memory is setup (if my understanding is correct).

Quoted 7 lines

After patching it, the machine launched and booted successfully with 512MB of RAM.

---
 hw/ppc4xx_devs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I shortened the commit message and dropped the first line of commit description ("I hope this is the right way of submitting QEMU patches.").

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan