Skip to contentSkip to conversation

: megaraid: avoid sleeping on spinlock

PATCH New Denis Efremov 1 participant 1 message Feb 21, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : megaraid: avoid sleeping on spinlock

GFP_KERNEL may cause pci_pool_alloc() sleep,
so we need use GFP_ATOMIC instead of GFP_KERNEL.

Found by Linux Driver Verification project (linuxtesting.org).

---
 drivers/scsi/megaraid/megaraid_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/megaraid/megaraid_mm.c +1 -1
index 25506c7..4b2f336 100644
@@ -568,7 +568,7 @@ mraid_mm_attach_buf(mraid_mmadp_t *adp, uioc_t *kioc, int xferlen)
 
 	kioc->pool_index	= right_pool;
 	kioc->free_buf		= 1;
-	kioc->buf_vaddr 	= pci_pool_alloc(pool->handle, GFP_KERNEL,
+	kioc->buf_vaddr 	= pci_pool_alloc(pool->handle, GFP_ATOMIC,
 							&kioc->buf_paddr);
 	spin_unlock_irqrestore(&pool->lock, flags);
 
Signature · 1 line
1.8.1.2