Skip to contentSkip to conversation

build.py: avoid deleting taint files when writing stamps

PATCH In review Paul Eggleton 2 participants 2 messages Feb 21, 2013 – Feb 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build.py: avoid deleting taint files when writing stamps

The stamp cleaning process that occurs before writing out new stamps for a task was deleting taint files as well. This resulted in tasks that were forcibly re-executed using the -f or -C command line options to have their previous output restored from shared state when called upon a second time, because the taint value was no longer incorporated into the task signature and thus it was reverting to its previous value. This also affected the kernel menuconfig command in OE-Core.

Note that the taint file *is* still deleted when doing -c clean, which is the desired behaviour.

Fixes [YOCTO #3919].

---
 lib/bb/build.py |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
lib/bb/build.py +4 -1
index 5f5a007..d91ff53 100644
@@ -519,10 +519,13 @@ def make_stamp(task, d, file_name = None):
     """
     cleanmask = stamp_cleanmask_internal(task, d, file_name)
     for mask in cleanmask:
-        # Preserve sigdata files in the stamps directory
         for name in glob.glob(mask):
+            # Preserve sigdata files in the stamps directory
             if "sigdata" in name:
                 continue
+            # Preserve taint files in the stamps directory
+            if name.endswith('.taint'):
+                continue
             os.unlink(name)
     
     stamp = stamp_internal(task, d, file_name)
Signature · 1 line
1.7.10.4
#1 lore raw

I have an image recipe (appending to core-image-minimal) that builds components specific to my project and I get a bzImage and a core-image-minimal.iso out of it. I want to add some bootloader code to be built as a separate entity like bzImage and not as part of the core-image-minimal.iso. Is there a way to do this in yocto?

Thanks,
Prana