Skip to contentSkip to conversation

ui/gtk: Fix build (missing include for setlocale)

PATCH Applied Stefan Weil 2 participants 4 messages Feb 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ui/gtk: Fix build (missing include for setlocale)

At least for Ubuntu Linux locale.h is needed.

---

This is a build regression, please apply without waiting for qemu-trivial.

Thanks,
Stefan

 ui/gtk.c |    1 +
 1 file changed, 1 insertion(+)
ui/gtk.c +1 -0
index 29156be..5f91de4 100644
@@ -37,6 +37,7 @@
 #include <gtk/gtk.h>
 #include <gdk/gdkkeysyms.h>
 #include <glib/gi18n.h>
+#include <locale.h>
 #include <vte/vte.h>
 #include <sys/types.h>
 #include <sys/socket.h>
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 3 lines · Stefan Weil

At least for Ubuntu Linux locale.h is needed.

Thanks, what version of Ubuntu? I'm running 11.10 and don't have this problem.

Regards,

Anthony Liguori

Quoted 24 lines

---

This is a build regression, please apply without waiting for qemu-trivial.

Thanks,
Stefan

 ui/gtk.c |    1 +
 1 file changed, 1 insertion(+)
ui/gtk.c +1 -0
index 29156be..5f91de4 100644
@@ -37,6 +37,7 @@
 #include <gtk/gtk.h>
 #include <gdk/gdkkeysyms.h>
 #include <glib/gi18n.h>
+#include <locale.h>
 #include <vte/vte.h>
 #include <sys/types.h>
 #include <sys/socket.h>
Signature · 1 line
1.7.10.4
#2 lore raw

Am 22.02.2013 14:14, schrieb Anthony Liguori:

Quoted 8 lines
Quoted 3 lines · Stefan Weil

At least for Ubuntu Linux locale.h is needed.

Thanks, what version of Ubuntu? I'm running 11.10 and don't have this problem.

It's needed for Ubuntu Precise 12.04.2 LTS (32 bit), the latest LTS version, so QEMU should support this environment.

I assume that other distributions include locale.h indirectly. The man page of setlocale explicitly says that locale.h is the required include file.

Regards,
Stefan Weil