Skip to contentSkip to conversation

log_srcrev.bbclass: add a bbclass for logging SRCREVs

PATCH Superseded Constantin Musca 2 participants 2 messages Feb 22, 2013 – Feb 26, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 log_srcrev.bbclass: add a bbclass for logging SRCREVs

- add a task which creates a file for each package with the following format:

BB_FILENAME: ${BB_FILENAME}
SRC_URI: ${SRC_URI}
SRCREV: ${SRCREV}
FROM AUTOREV: no/yes

[YOCTO #3041]

---
 meta/classes/log_srcrev.bbclass | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/classes/log_srcrev.bbclass
meta/classes/log_srcrev.bbclass new file +20 -0
new file mode 100644
index 0000000..b319e7b
@@ -0,0 +1,20 @@
+SRCREV_LOGFILE ??= 'srcrev_log'
+
+python do_log_srcrev () {
+    srcrev = d.getVar('SRCREV', True)
+    if srcrev:
+        bbfile = d.getVar('BB_FILENAME', True)
+        src_uri = d.getVar('SRC_URI', True)
+        from_autorev = 'yes' if d.getVar('SRCREV', False) == 'AUTOINC' else 'no'
+
+        srcrevdir = d.expand('${TMPDIR}/srcrevs/${MULTIMACH_TARGET_SYS}/${PN}-${PV}/')
+        srcrevfile = os.path.join(srcrevdir, d.getVar('SRCREV_LOGFILE', True))
+        bb.utils.mkdirhier(os.path.dirname(srcrevfile))
+
+        with open(srcrevfile, 'w') as f:
+            f.write("BB_FILENAME: %s\nSRC_URI: %s\nSRCREV: %s\nFROM AUTOREV: %s\n"
+                    % (bbfile, src_uri, srcrev, from_autorev))
+}
+
+addtask do_log_srcrev after do_fetch
+do_log_srcrev[cleandirs] = "${TMPDIR}/srcrevs/${MULTIMACH_TARGET_SYS}/${PN}-${PV}/"
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 8 lines · Constantin Musca

- add a task which creates a file for each package with the following format:

BB_FILENAME: ${BB_FILENAME}
SRC_URI: ${SRC_URI}
SRCREV: ${SRCREV}
FROM AUTOREV: no/yes

Would it be better to have the format more as a CSV

bbfilename,src_uri,srcrev,autorev?

This would make it easier to parse for scripts

Jerrod, you are the requester on this, do you have any comments on the format?

Quoted 17 lines

[YOCTO #3041]

---
  meta/classes/log_srcrev.bbclass | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

create mode 100644 meta/classes/log_srcrev.bbclass

meta/classes/log_srcrev.bbclass new file +3 -0
new file mode 100644
index 0000000..b319e7b
@@ -0,0 +1,20 @@
+SRCREV_LOGFILE ??= 'srcrev_log'
+
+python do_log_srcrev () {

meta/classes/log_srcrev.bbclass line 13

Quoted 10 lines
meta/classes/log_srcrev.bbclass new file +10 -0
+    srcrev = d.getVar('SRCREV', True)
+    if srcrev:
+        bbfile = d.getVar('BB_FILENAME', True)
+        src_uri = d.getVar('SRC_URI', True)
+        from_autorev = 'yes' if d.getVar('SRCREV', False) == 'AUTOINC' else 'no'
+
+        srcrevdir = d.expand('${TMPDIR}/srcrevs/${MULTIMACH_TARGET_SYS}/${PN}-${PV}/')
+        srcrevfile = os.path.join(srcrevdir, d.getVar('SRCREV_LOGFILE', True))
+        bb.utils.mkdirhier(os.path.dirname(srcrevfile))
+

Do we really need the extra level of directory here? Can the data be contained in a ${PN}-${PV} file instead? Also this might be better to be ${BP} (base package & version).

You already have the mulitlib info in the ${MULTIMACH_TARGET_SYS} info.

Thanks
Sau!

Quoted 8 lines
meta/classes/log_srcrev.bbclass new file +7 -0
+        with open(srcrevfile, 'w') as f:
+            f.write("BB_FILENAME: %s\nSRC_URI: %s\nSRCREV: %s\nFROM AUTOREV: %s\n"
+                    % (bbfile, src_uri, srcrev, from_autorev))
+}
+
+addtask do_log_srcrev after do_fetch
+do_log_srcrev[cleandirs] = "${TMPDIR}/srcrevs/${MULTIMACH_TARGET_SYS}/${PN}-${PV}/"