Skip to contentSkip to conversation

parted: fix several integer overflows

PATCH In review Ming Liu 2 participants 3 messages Feb 25, 2013 – Feb 26, 2013

lore
Share & tools
lore

Ming Liu

author
#0 lore raw

PATCH 1/1 parted: fix several integer overflows

Integer overflows was found in libparted/labels/dvh.c, while attemptting assign unsigned int values to int types in some places. These overflows only can be observed on BE platforms like MIPS, when the "WORDS_BIGENDIAN" macro is defined in parted.

Defined by unsigned int instead.

---
 .../parted/parted-3.1/fix-dvh-overflows.patch      | 34 ++++++++++++++++++++++
 meta/recipes-extended/parted/parted_3.1.bb         |  5 ++--
 2 files changed, 37 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch
meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +34 -0
new file mode 100644
index 0000000..0768642
@@ -0,0 +1,34 @@
+Upstream-Status: Pending
+
+---
+ dvh.h |   10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+Index: parted-3.1/libparted/labels/dvh.h
+===================================================================
+--- parted-3.1.orig/libparted/labels/dvh.h	2013-02-25 10:46:13.204477586 +0800
++++ parted-3.1/libparted/labels/dvh.h	2013-02-25 10:47:20.954477065 +0800
+@@ -112,8 +112,8 @@ struct device_parameters {
+ 
+ struct volume_directory {
+ 	char	vd_name[VDNAMESIZE];	/* name */
+-	int	vd_lbn;			/* logical block number */
+-	int	vd_nbytes;		/* file length in bytes */
++	unsigned int	vd_lbn;		/* logical block number */
++	unsigned int	vd_nbytes;	/* file length in bytes */
+ };
+ 
+ /*
+@@ -125,9 +125,9 @@ struct volume_directory {
+  * NOTE: pt_firstlbn SHOULD BE CYLINDER ALIGNED
+  */
+ struct partition_table {		/* one per logical partition */
+-	int	pt_nblks;		/* # of logical blks in partition */
+-	int	pt_firstlbn;		/* first lbn of partition */
+-	int	pt_type;		/* use of partition */
++	unsigned int	pt_nblks;	/* # of logical blks in partition */
++	unsigned int	pt_firstlbn;	/* first lbn of partition */
++	int		pt_type;	/* use of partition */
+ };
+ 
+ #define	PTYPE_VOLHDR	0		/* partition is volume header */
meta/recipes-extended/parted/parted_3.1.bb +3 -2
index 21d3a66..079b295 100644
@@ -4,13 +4,14 @@ LICENSE = "GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=2f31b266d3440dd7ee50f92cf67d8e6c"
 SECTION = "console/tools"
 DEPENDS = "ncurses readline util-linux"
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
            file://no_check.patch \
            file://syscalls.patch \
            file://fix-git-version-gen.patch \
-           file://fix-doc-mandir.patch"
+           file://fix-doc-mandir.patch \
+           file://fix-dvh-overflows.patch"
 
 SRC_URI[md5sum] = "5d89d64d94bcfefa9ce8f59f4b81bdcb"
 SRC_URI[sha256sum] = "5e9cc1f91eaf016e5033d85b9b893fd6d3ffaca532a48de1082df9b94225ca15"
Signature · 1 line
1.7.11
#1 lore raw
Quoted 20 lines · Ming Liu

Integer overflows was found in libparted/labels/dvh.c, while attemptting assign unsigned int values to int types in some places. These overflows only can be observed on BE platforms like MIPS, when the "WORDS_BIGENDIAN" macro is defined in parted.

Defined by unsigned int instead.

---
  .../parted/parted-3.1/fix-dvh-overflows.patch      | 34 ++++++++++++++++++++++
  meta/recipes-extended/parted/parted_3.1.bb         |  5 ++--
  2 files changed, 37 insertions(+), 2 deletions(-)

create mode 100644 meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch

meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +0 -0
new file mode 100644
index 0000000..0768642

meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch line 2

Quoted 2 lines
meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +2 -0
@@ -0,0 +1,34 @@
+Upstream-Status: Pending
+

Please add Signed-off-by: to the patch also.

Thanks
Sau!

Quoted 54 lines
meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +32 -0
+---
+ dvh.h |   10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+Index: parted-3.1/libparted/labels/dvh.h
+===================================================================
+--- parted-3.1.orig/libparted/labels/dvh.h	2013-02-25 10:46:13.204477586 +0800
++++ parted-3.1/libparted/labels/dvh.h	2013-02-25 10:47:20.954477065 +0800
+@@ -112,8 +112,8 @@ struct device_parameters {
+
+ struct volume_directory {
+ 	char	vd_name[VDNAMESIZE];	/* name */
+-	int	vd_lbn;			/* logical block number */
+-	int	vd_nbytes;		/* file length in bytes */
++	unsigned int	vd_lbn;		/* logical block number */
++	unsigned int	vd_nbytes;	/* file length in bytes */
+ };
+
+ /*
+@@ -125,9 +125,9 @@ struct volume_directory {
+  * NOTE: pt_firstlbn SHOULD BE CYLINDER ALIGNED
+  */
+ struct partition_table {		/* one per logical partition */
+-	int	pt_nblks;		/* # of logical blks in partition */
+-	int	pt_firstlbn;		/* first lbn of partition */
+-	int	pt_type;		/* use of partition */
++	unsigned int	pt_nblks;	/* # of logical blks in partition */
++	unsigned int	pt_firstlbn;	/* first lbn of partition */
++	int		pt_type;	/* use of partition */
+ };
+
+ #define	PTYPE_VOLHDR	0		/* partition is volume header */
meta/recipes-extended/parted/parted_3.1.bb +3 -2
index 21d3a66..079b295 100644
@@ -4,13 +4,14 @@ LICENSE = "GPLv3+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=2f31b266d3440dd7ee50f92cf67d8e6c"
  SECTION = "console/tools"
  DEPENDS = "ncurses readline util-linux"
-PR = "r0"
+PR = "r1"
 
  SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
             file://no_check.patch \
             file://syscalls.patch \
             file://fix-git-version-gen.patch \
-           file://fix-doc-mandir.patch"
+           file://fix-doc-mandir.patch \
+           file://fix-dvh-overflows.patch"
 
  SRC_URI[md5sum] = "5d89d64d94bcfefa9ce8f59f4b81bdcb"
  SRC_URI[sha256sum] = "5e9cc1f91eaf016e5033d85b9b893fd6d3ffaca532a48de1082df9b94225ca15"
author
#2 lore raw
Quoted 17 lines · Saul Wold
Quoted 16 lines · Ming Liu

Integer overflows was found in libparted/labels/dvh.c, while attemptting assign unsigned int values to int types in some places. These overflows only can be observed on BE platforms like MIPS, when the "WORDS_BIGENDIAN" macro is defined in parted.

Defined by unsigned int instead.

---
  .../parted/parted-3.1/fix-dvh-overflows.patch      | 34 
++++++++++++++++++++++
  meta/recipes-extended/parted/parted_3.1.bb         |  5 ++--
  2 files changed, 37 insertions(+), 2 deletions(-)

create mode 100644
meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch

Quoted 9 lines

meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch line 2

Quoted 8 lines
meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +2 -0
new file mode 100644
index 0000000..0768642
@@ -0,0 +1,34 @@
+Upstream-Status: Pending
+

Please add Signed-off-by: to the patch also.

OK, got it. I will send V1.

the best,
thank you

Quoted 64 lines

Thanks
Sau!

Quoted 58 lines
meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +7 -0
+---
+ dvh.h |   10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+Index: parted-3.1/libparted/labels/dvh.h
+===================================================================
+--- parted-3.1.orig/libparted/labels/dvh.h    2013-02-25 

10:46:13.204477586 +0800
++++ parted-3.1/libparted/labels/dvh.h 2013-02-25
10:47:20.954477065 +0800
+@@ -112,8 +112,8 @@ struct device_parameters {

meta/recipes-extended/parted/parted-3.1/fix-dvh-overflows.patch new file +23 -0
+
+ struct volume_directory {
+     char    vd_name[VDNAMESIZE];    /* name */
+-    int    vd_lbn;            /* logical block number */
+-    int    vd_nbytes;        /* file length in bytes */
++    unsigned int    vd_lbn;        /* logical block number */
++    unsigned int    vd_nbytes;    /* file length in bytes */
+ };
+
+ /*
+@@ -125,9 +125,9 @@ struct volume_directory {
+  * NOTE: pt_firstlbn SHOULD BE CYLINDER ALIGNED
+  */
+ struct partition_table {        /* one per logical partition */
+-    int    pt_nblks;        /* # of logical blks in partition */
+-    int    pt_firstlbn;        /* first lbn of partition */
+-    int    pt_type;        /* use of partition */
++    unsigned int    pt_nblks;    /* # of logical blks in partition */
++    unsigned int    pt_firstlbn;    /* first lbn of partition */
++    int        pt_type;    /* use of partition */
+ };
+
+ #define    PTYPE_VOLHDR    0        /* partition is volume header */
meta/recipes-extended/parted/parted_3.1.bb +0 -0
index 21d3a66..079b295 100644
@@ -4,13 +4,14 @@ LICENSE = "GPLv3+"
  LIC_FILES_CHKSUM = 

"file://COPYING;md5=2f31b266d3440dd7ee50f92cf67d8e6c"
SECTION = "console/tools"
DEPENDS = "ncurses readline util-linux"

meta/recipes-extended/parted/parted_3.1.bb +3 -2
-PR = "r0"
+PR = "r1"
 
  SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
             file://no_check.patch \
             file://syscalls.patch \
             file://fix-git-version-gen.patch \
-           file://fix-doc-mandir.patch"
+           file://fix-doc-mandir.patch \
+           file://fix-dvh-overflows.patch"
 
  SRC_URI[md5sum] = "5d89d64d94bcfefa9ce8f59f4b81bdcb"
  SRC_URI[sha256sum] = 

"5e9cc1f91eaf016e5033d85b9b893fd6d3ffaca532a48de1082df9b94225ca15"