debug_locks.h: make warning more verbose
PATCH 1/1 debug_locks.h: make warning more verbose
The WARN_ON(1) in DEBUG_LOCKS_WARN_ON is surprisingly awkward to track down when it's hit, as it's usually buried in macros, causing multiple instances to land on the same line number.
This patch makes it more useful by switching to:
WARN(1, "DEBUG_LOCKS_WARN_ON(%s)", #c);
so that the particular DEBUG_LOCKS_WARN_ON is more easily identified and grep'd for. For example:
WARNING: at kernel/mutex.c:198 _mutex_lock_nested+0x31c/0x380()
DEBUG_LOCKS_WARN_ON(l->magic != l)Signed-off-by James Hogan <[email protected]>
Cc Paul Gortmaker <[email protected]>
Cc David Howells <[email protected]>
--- include/linux/debug_locks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/debug_locks.h +1 -1
@@ -27,7 +27,7 @@ extern int debug_locks_off(void); \if (!oops_in_progress &&unlikely (c)) { \if (debug_locks_off () && !debug_locks_silent) \ -WARN_ON (1 ); \ + WARN(1, "DEBUG_LOCKS_WARN_ON(%s)", #c); \ __ret =1 ; \ } \ __ret; \
Signature · 1 line
1.8.1.2