Skip to contentSkip to conversation

systemd: set the location of the kill binary

PATCH In review Ross Burton 4 participants 7 messages Feb 26, 2013 – Feb 27, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 systemd: set the location of the kill binary

Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't work on the target.

---
 meta/recipes-core/systemd/systemd_197.bb |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/systemd/systemd_197.bb +1 -0
index c765c18..001d111 100644
@@ -63,6 +63,7 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
                  --disable-microhttpd \
                  --without-python \
                  --with-sysvrcnd-path=${sysconfdir} \
+                 ac_cv_path_KILL=/bin/kill \
                "
 # uclibc does not have NSS
 EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
Signature · 1 line
1.7.10.4
#2 lore raw
Quoted 7 lines · Otavio Salvador
Quoted 4 lines · Ross Burton

Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't work on the target.

Now I saw the Khem suggestion to use /usr/bin/env kill; seems good.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#3 lore raw
Quoted 11 lines · Otavio Salvador
Quoted 7 lines · Otavio Salvador
Quoted 4 lines · Ross Burton

Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't work on the target.

Now I saw the Khem suggestion to use /usr/bin/env kill; seems good.

If it wants a target path then "/usr/bin/env kill" would fail for targets that either don't have /usr or don't have "env" installed. That might not be so good.

/usr/bin/env would be fine if we were talking about a build host path but that doesn't appear to be the case here.

p.

#4 lore raw
In reply to Ross Burton
Quoted 13 lines · Ross Burton

Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't work on the target.

---
 meta/recipes-core/systemd/systemd_197.bb |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/systemd/systemd_197.bb +0 -0
index c765c18..001d111 100644

meta/recipes-core/systemd/systemd_197.bb EXTRA_OECONF = " --with-rootprefix=${base_prefix} \ · line 66

Quoted 4 lines
meta/recipes-core/systemd/systemd_197.bb +1 -0
@@ -63,6 +63,7 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
                  --disable-microhttpd \
                  --without-python \
                  --with-sysvrcnd-path=${sysconfdir} \
+                 ac_cv_path_KILL=/bin/kill \

${base_bindir} ?

#5 lore raw
In reply to Ross Burton
Quoted 13 lines · Ross Burton

Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't work on the target.

---
 meta/recipes-core/systemd/systemd_197.bb |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/systemd/systemd_197.bb +0 -0
index c765c18..001d111 100644

meta/recipes-core/systemd/systemd_197.bb EXTRA_OECONF = " --with-rootprefix=${base_prefix} \ · line 66

Quoted 4 lines
meta/recipes-core/systemd/systemd_197.bb +1 -0
@@ -63,6 +63,7 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
                  --disable-microhttpd \
                  --without-python \
                  --with-sysvrcnd-path=${sysconfdir} \
+                 ac_cv_path_KILL=/bin/kill \

Like V1 this hardcodes ${base_bindir} to /bin, this breaks when your DISTRO sets $base_prefix to /usr. So please change that to:

	ac_cv_path+KILL=${base_bindir}/kill
#6 lore raw
Quoted 4 lines · Koen Kooi

Like V1 this hardcodes ${base_bindir} to /bin, this breaks when your DISTRO sets $base_prefix to /usr. So please change that to:

        ac_cv_path+KILL=${base_bindir}/kill

Yeah, not sure why I did that. :/ V2 coming shortly.

Ross