Skip to contentSkip to conversation

Read CTF by the ctf target

PATCH Hui Zhu 3 participants 4 messages Mar 1, 2013 – May 7, 2013 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Hui Zhu

author
#3 lore raw
Quoted 4 lines · Pedro Alves

(not a complete review)

On 02/27/2013 02:17 AM, Yao Qi wrote:

Quoted 14 lines

Review

Quoted 8 lines
(quoted diff) +8 -0
+if test "x$with_babeltrace" != "xno"; then
+  saved_CFLAGS="$CFLAGS"
+  CFLAGS="$CFLAGS $btinc"
+  AC_MSG_CHECKING([for babeltrace])
+  AC_TRY_COMPILE([
+#include <babeltrace/babeltrace.h>
+#include <babeltrace/ctf/events.h>
+#include <babeltrace/ctf/iterator.h>

We know from previous patches that the latest released babeltrace breaks gdb, due to the lookup_enum function. Does this catch that? I see namespacing fixes going into babeltrace as recently as last 15th. Do we know if babeltrace's API is more or less done and close to a release?

Hi Mathieu,

Could you help us with this question?

Thanks,
Hui

Quoted 18 lines

Review

Quoted 8 lines
(quoted diff) +7 -0
+  ],[],
+  [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])],
+  [AC_MSG_RESULT([no]); btlibs= ; btinc= ])
+  CFLAGS="$saved_CFLAGS"
+fi
+
+# Flags needed for UST

babeltrace

Review

Quoted 3 lines
(quoted diff) +3 -0
+AC_SUBST(btlibs)
+AC_SUBST(btinc)
+

--
Pedro Alves

#4 lore raw
Quoted 20 lines · * Hui Zhu ([email protected]) wrote:
Quoted 4 lines · Pedro Alves

(not a complete review)

On 02/27/2013 02:17 AM, Yao Qi wrote:

Quoted 14 lines

Review

Quoted 8 lines
(quoted diff) +8 -0
+if test "x$with_babeltrace" != "xno"; then
+  saved_CFLAGS="$CFLAGS"
+  CFLAGS="$CFLAGS $btinc"
+  AC_MSG_CHECKING([for babeltrace])
+  AC_TRY_COMPILE([
+#include <babeltrace/babeltrace.h>
+#include <babeltrace/ctf/events.h>
+#include <babeltrace/ctf/iterator.h>

We know from previous patches that the latest released babeltrace breaks gdb, due to the lookup_enum function. Does this catch that? I see namespacing fixes going into babeltrace as recently as last 15th. Do we know if babeltrace's API is more or less done and close to a release?

Quoted 3 lines

Hi Mathieu,

Could you help us with this question?

We did the 1.1.0 release specifically for namespace fixes on March 23rd.

commit c99b1910bea848e8f0ae5641bb63b8f4f84f3ec0

Author: Mathieu Desnoyers <[email protected]>
Date:   Sat Mar 23 13:34:22 2013 -0400

Version 1.1.0

Thanks,

Mathieu

Quoted 22 lines

Thanks,
Hui

Quoted 18 lines

Review

Quoted 8 lines
(quoted diff) +7 -0
+  ],[],
+  [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])],
+  [AC_MSG_RESULT([no]); btlibs= ; btinc= ])
+  CFLAGS="$saved_CFLAGS"
+fi
+
+# Flags needed for UST

babeltrace

Review

Quoted 3 lines
(quoted diff) +3 -0
+AC_SUBST(btlibs)
+AC_SUBST(btinc)
+

--
Pedro Alves

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
#5 lore raw
Quoted 9 lines · Mathieu Desnoyers

We did the 1.1.0 release specifically for namespace fixes on March 23rd.

commit c99b1910bea848e8f0ae5641bb63b8f4f84f3ec0

Author: Mathieu Desnoyers<[email protected]>
Date:   Sat Mar 23 13:34:22 2013 -0400

Version 1.1.0

Mathieu,
We noticed this timely release and start to use babeltrace 1.1.0 in GDB.
GDB is able read ctf via babeltrace now, just fyi... and thanks for
your help on some ctf explanations.

Signature · 1 line
Yao (齐尧)
#6 lore raw
Quoted 7 lines · * Yao Qi ([email protected]) wrote:
Quoted 6 lines · Mathieu Desnoyers

We did the 1.1.0 release specifically for namespace fixes on March 23rd.

commit c99b1910bea848e8f0ae5641bb63b8f4f84f3ec0

Author: Mathieu Desnoyers<[email protected]>
Date:   Sat Mar 23 13:34:22 2013 -0400
Quoted 8 lines
Quoted 3 lines

Version 1.1.0

Mathieu,
We noticed this timely release and start to use babeltrace 1.1.0 in GDB.
GDB is able read ctf via babeltrace now, just fyi... and thanks for
your help on some ctf explanations.

That's great !

Thank you,

Mathieu

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com