Skip to contentSkip to conversation

misc/vmw_vmci: Add dependency on CONFIG_NET

PATCH In review Guenter Roeck 2 participants 2 messages Feb 27, 2013 – Mar 8, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc/vmw_vmci: Add dependency on CONFIG_NET

Building the vmw_vmci driver with CONFIG_NET undefined results in:

drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.13':
vmci_queue_pair.c:(.text+0x1671a8): undefined reference to memcpy_toiovec' drivers/built-in.o: In function __qp_memcpy_to_queue.isra.14':
vmci_queue_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec' make[1]: [vmlinux] Error 1 (ignored)

since memcpy_toiovec and memcpy_fromiovec are defined in the networking code. Add the missing dependency.

---
 drivers/misc/vmw_vmci/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_vmci/Kconfig +1 -1
index 39c2eca..ea98f7e 100644
@@ -4,7 +4,7 @@
 
 config VMWARE_VMCI
 	tristate "VMware VMCI Driver"
-	depends on X86 && PCI
+	depends on X86 && PCI && NET
 	help
 	  This is VMware's Virtual Machine Communication Interface.  It enables
 	  high-speed communication between host and guest in a virtual
Signature · 1 line
1.7.9.7
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Guenter Roeck

Building the vmw_vmci driver with CONFIG_NET undefined results in:

drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.13':
vmci_queue_pair.c:(.text+0x1671a8): undefined reference to memcpy_toiovec' drivers/built-in.o: In function __qp_memcpy_to_queue.isra.14':
vmci_queue_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec' make[1]: [vmlinux] Error 1 (ignored)

Quoted 4 lines

since memcpy_toiovec and memcpy_fromiovec are defined in the networking code. Add the missing dependency.

Thanks.

Quoted 18 lines
---
 drivers/misc/vmw_vmci/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_vmci/Kconfig +1 -1
index 39c2eca..ea98f7e 100644
@@ -4,7 +4,7 @@
 
 config VMWARE_VMCI
 	tristate "VMware VMCI Driver"
-	depends on X86 && PCI
+	depends on X86 && PCI && NET
 	help
 	  This is VMware's Virtual Machine Communication Interface.  It enables
 	  high-speed communication between host and guest in a virtual
Signature · 1 line
~Randy