IIO break info_mask into a pair of masks - Additional drivers
Subsystems (3)
Jonathan Cameron
maintainercover IIO break info_mask into a pair of masks - Additional drivers
Hi All,
This short series applies the equivalent changes to the two new drivers to enter the IIO tree whilst the series in
[PATCH 00/67 V2] IIO break info_mask into a pair of masks was under way.
If there are no issues, I'll slot these in just before patch 67 of that series.
As a quick summary for anyone just looking at these, I am proposing to split info_mask into info_mask_separate and info_mask_shared_by_type so as to simplify the handling, shorten the code and make more space for new elements. With the benefit of hindsight info_mask should have been done like this in the first place.
Jonathan
Jonathan Cameron (2):
iio:adc:exynos move to info_mask_(shared_by_type/separate) iio:adc:ad7923 move to info_mask_(shared_by_type/separate)
drivers/iio/adc/ad7923.c | 4 ++-- drivers/iio/adc/exynos_adc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.4
Jonathan Cameron
maintainerPATCH 1/2 iio:adc:exynos move to info_mask_(shared_by_type/separate)
The original info_mask is going away in favour of the broken out versions.
--- drivers/iio/adc/exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/exynos_adc.c +1 -1
@@ -198,7 +198,7 @@ static const struct iio_info exynos_adc_iio_info = { .indexed = 1, \ .channel = _index, \ .address = _index, \ - .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ .datasheet_name = _id, \ }
Signature · 1 line
1.8.1.4
Re: [PATCH 1/2] iio:adc:exynos move to info_mask_(shared_by_type/separate)
Quoted 4 lines · Jonathan Cameron
The original
info_maskis going away in favour of the broken out versions.Signed-off-by Jonathan Cameron <[email protected]>cc Naveen Krishna Chatradhi <[email protected]>
Thanks, Jonathan.
Quoted 20 lines
--- drivers/iio/adc/exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/exynos_adc.c +1
-2@@ -198,7 +198,7 @@ static const struct iio_info exynos_adc_iio_info = { .indexed = 1, \ .channel = _index, \ .address = _index, \ - .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ .datasheet_name = _id, \ } --1.8.1.4
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Shine bright,
(: Nav :)
Jonathan Cameron
maintainerRe: [PATCH 1/2] iio:adc:exynos move to info_mask_(shared_by_type/separate)
Quoted 6 lines · Naveen Krishna Ch
Quoted 4 lines · Jonathan Cameron
The original
info_maskis going away in favour of the broken out versions.Signed-off-by Jonathan Cameron <[email protected]>cc Naveen Krishna Chatradhi <[email protected]>Thanks, Jonathan.
While thanks is always nice, I took that as counting as an Acked-by tag. Shout if you would rather I didn't!
Quoted 35 lines
Quoted 20 lines
--- drivers/iio/adc/exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/exynos_adc.c +1
-2@@ -198,7 +198,7 @@ static const struct iio_info exynos_adc_iio_info = { .indexed = 1, \ .channel = _index, \ .address = _index, \ - .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ .datasheet_name = _id, \ } --1.8.1.4
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jonathan Cameron
maintainerPATCH 2/2 iio:adc:ad7923 move to info_mask_(shared_by_type/separate)
In reply to Jonathan CameronThe original info_mask is going away in favour of the broken out versions.
--- drivers/iio/adc/ad7923.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ad7923.c +2 -2
@@ -69,8 +69,8 @@ struct ad7923_state { .type = IIO_VOLTAGE, \ .indexed = 1, \ .channel = index, \ - .info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT | \ - IIO_CHAN_INFO_SCALE_SHARED_BIT, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ .address = index, \ .scan_index = index, \ .scan_type = { \
Signature · 1 line
1.8.1.4