Skip to contentSkip to conversation

scripts/mod: add device table offsets file to list of files to clean

PATCH In review Fernando Luis Vázquez Cao 2 participants 3 messages Mar 4, 2013 – Apr 8, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/mod: add device table offsets file to list of files to clean

From: Fernando Luis Vázquez Cao <[email protected]>

This file is generated so it does not get cleaned automagically. In other words we need to added to the clean-files list.

---

scripts/mod/Makefile +2 -0
diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile
@@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
 	$(call if_changed,elfconfig)
 
 targets += elfconfig.h
+
+clean-files	:= $(devicetable-offsets-file)
#1 lore raw

Hi Michal,

Quoted 12 lines · Fernando Luis Vázquez Cao

From: Fernando Luis Vázquez Cao <[email protected]>

This file is generated so it does not get cleaned automagically. In other words we need to added to the clean-files list.

---

diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile

scripts/mod/Makefile $(obj)/elfconfig.h: $(obj)/empty.o $(obj · line 53

Quoted 5 lines
scripts/mod/Makefile +2 -0
@@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
  	$(call if_changed,elfconfig)
 
  targets += elfconfig.h
+
+clean-files	:= $(devicetable-offsets-file)

Do you see any problem with this patch?

Thanks,
Fernando

#2 lore raw
Quoted 12 lines · Fernando Luis Vazquez Cao

Hi Michal,

Quoted 9 lines · Fernando Luis Vázquez Cao

From: Fernando Luis Vázquez Cao <[email protected]>

This file is generated so it does not get cleaned automagically. In other words
we need to added to the clean-files list.

---

Quoted 13 lines

scripts/mod/Makefile $(obj)/elfconfig.h: $(obj)/empty.o $(obj · line 52

Quoted 11 lines

diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile
--- linux-3.9-rc1-orig/scripts/mod/Makefile 2013-03-04
16:09:29.297904000 +0900
+++ linux-3.9-rc1/scripts/mod/Makefile 2013-03-04
18:06:16.359389000 +0900

scripts/mod/Makefile +2 -0
@@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
      $(call if_changed,elfconfig)
    targets += elfconfig.h
+
+clean-files    := $(devicetable-offsets-file)

Do you see any problem with this patch?

Yes, it does not work, at least not on top of 3.9-rc1. You need to add 'scripts' to the $(clean-dirs) list in the main Makefile, so that make clean descends into scripts/mod.

Michal