Skip to contentSkip to conversation

libtraceevent: remove hard coded include to /usr/local/include in Makefile

PATCH In review Jack Mitchell 3 participants 3 messages Mar 8, 2013 – Mar 18, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtraceevent: remove hard coded include to /usr/local/include in Makefile

From: Jack Mitchell <[email protected]>

having /usr/local/include hardcoded into the makefile is not necessary as this is automatically included by GCC. It also infects cross-compile builds with the host systems includes.

---
 tools/lib/traceevent/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/traceevent/Makefile +1 -1
index a20e320..0b0a907 100644
@@ -122,7 +122,7 @@ export Q VERBOSE
 
 EVENT_PARSE_VERSION = $(EP_VERSION).$(EP_PATCHLEVEL).$(EP_EXTRAVERSION)
 
-INCLUDES = -I. -I/usr/local/include $(CONFIG_INCLUDES)
+INCLUDES = -I. $(CONFIG_INCLUDES)
 
 # Set compile option CFLAGS if not set elsewhere
 CFLAGS ?= -g -Wall
Signature · 1 line
1.8.1.5
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jack Mitchell

From: Jack Mitchell <[email protected]>

having /usr/local/include hardcoded into the makefile is not necessary as this is automatically included by GCC. It also infects cross-compile builds with the host systems includes.

Thanks,
Namhyung

#2 lore raw

[tip:perf/urgent] libtraceevent: Remove hard coded include to / usr/local/include in Makefile

In reply to Jack Mitchell
libtraceevent: Remove hard coded include to /usr/local/include in Makefile
Commit-ID:  b9e8c37220c80e78289a1e87b50c09418eb59a7e
Gitweb:     http://git.kernel.org/tip/b9e8c37220c80e78289a1e87b50c09418eb59a7e
Author:     Jack Mitchell <[email protected]>
AuthorDate: Fri, 8 Mar 2013 11:21:52 +0000
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 13 Mar 2013 17:00:00 -0300

libtraceevent: Remove hard coded include to /usr/local/include in Makefile

having /usr/local/include hardcoded into the makefile is not necessary as this is automatically included by GCC. It also infects cross-compile builds with the host systems includes.

---
 tools/lib/traceevent/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/traceevent/Makefile +1 -1
index a20e320..0b0a907 100644
@@ -122,7 +122,7 @@ export Q VERBOSE
 
 EVENT_PARSE_VERSION = $(EP_VERSION).$(EP_PATCHLEVEL).$(EP_EXTRAVERSION)
 
-INCLUDES = -I. -I/usr/local/include $(CONFIG_INCLUDES)
+INCLUDES = -I. $(CONFIG_INCLUDES)
 
 # Set compile option CFLAGS if not set elsewhere
 CFLAGS ?= -g -Wall