Skip to contentSkip to conversation

xfstests: determine path of logger

PATCH In review David Sterba 3 participants 3 messages Mar 11, 2013 – Mar 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: determine path of logger

The path of the syslog writer utility 'logger' is hardcoded and not always correct, use set_prog_path.

---
 check         | 2 +-
 common.config | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
check +1 -1
index c20179c..9a5b256 100755
@@ -243,7 +243,7 @@ do
 	start=`_wallclock`
 	$timestamp && echo -n "	["`date "+%T"`"]"
 	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
-	[ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
+	$LOGGER_PROG "run xfstest $seq"
 	./$seq >$tmp.rawout 2>&1
 	sts=$?
 	$timestamp && _timestamp
common.config +1 -0
index a0b017d..ed0f44c 100644
@@ -177,6 +177,7 @@ export DUMPE2FS_PROG="`set_prog_path dumpe2fs`"
 export FIO_PROG="`set_prog_path fio`"
 export FILEFRAG_PROG="`set_prog_path filefrag`"
 export E4DEFRAG_PROG="`set_prog_path e4defrag`"
+export LOGGER_PROG="`set_prog_path logger`"
 
 # Generate a comparable xfsprogs version number in the form of
 # major * 10000 + minor * 100 + release
Signature · 6 lines
1.8.1.4

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · David Sterba

The path of the syslog writer utility 'logger' is hardcoded and not always correct, use set_prog_path.

---
 check         | 2 +-
 common.config | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
check +1 -1
index c20179c..9a5b256 100755
@@ -243,7 +243,7 @@ do
 	start=`_wallclock`
 	$timestamp && echo -n "	["`date "+%T"`"]"
 	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
-	[ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
+	$LOGGER_PROG "run xfstest $seq"
 	./$seq >$tmp.rawout 2>&1
 	sts=$?
 	$timestamp && _timestamp
common.config +0 -0
index a0b017d..ed0f44c 100644

common.config export DUMPE2FS_PROG="`set_prog_path dumpe2fs`" · line 183

Quoted 7 lines
common.config +1 -0
@@ -177,6 +177,7 @@ export DUMPE2FS_PROG="`set_prog_path dumpe2fs`"
 export FIO_PROG="`set_prog_path fio`"
 export FILEFRAG_PROG="`set_prog_path filefrag`"
 export E4DEFRAG_PROG="`set_prog_path e4defrag`"
+export LOGGER_PROG="`set_prog_path logger`"
 
 # Generate a comparable xfsprogs version number in the form of
 # major * 10000 + minor * 100 + release

Looks good.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by Dave Chinner on v1 1/1
#2 lore raw
In reply to David Sterba

This patch has been committed.

Regards
--Rich

commit 9958693bdb282adc422bcf85f5360e3a5785e8e9

Author: David Sterba <[email protected]>
Date:   Mon Mar 11 23:36:52 2013 +0000

xfstests: determine path of logger

The path of the syslog writer utility 'logger' is hardcoded and not always correct, use set_prog_path.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs