Skip to contentSkip to conversation

Btrfs-progs: alloc our super copy in btrfs-find-root

PATCH In review Josef Bacik 2 participants 2 messages Mar 12, 2013 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Btrfs-progs: alloc our super copy in btrfs-find-root

Dave fixed the fs_info to allocate the super copy instead of embedding it, but he failed to notice that I open code open_ctree in btrfs-find-root so we end up with a super that's not allocated, so we segfault whenever you try to run btrfs-find-root. I've fixed this up and now we don't segfault anymore. Thanks,

---
 find-root.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
find-root.c +1 -0
index f99fb76..810d835 100644
@@ -116,6 +116,7 @@ static struct btrfs_root *open_ctree_broken(int fd, const char *device)
 	}
 
 	memset(fs_info, 0, sizeof(*fs_info));
+	fs_info->super_copy = calloc(1, BTRFS_SUPER_INFO_SIZE);
 	fs_info->tree_root = tree_root;
 	fs_info->extent_root = extent_root;
 	fs_info->chunk_root = chunk_root;
Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 4 lines · Josef Bacik

Dave fixed the fs_info to allocate the super copy instead of embedding it, but he failed to notice that I open code open_ctree in btrfs-find-root so we end up with a super that's not allocated, so we segfault whenever you try to run btrfs-find-root. I've fixed this up and now we don't segfault anymore. Thanks,

Sorry about that, patch queued.

david