Add comments to explain watchdog_disabled variable
PATCH 1/1 Add comments to explain watchdog_disabled variable
From: anish kumar <[email protected]>
This watchdog_disabled flag is a bit cryptic. However it's usefulness is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.
--- kernel/watchdog.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +5 -0
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,return ret;set_sample_period (); +/* +* Watchdog threads shouldn't be enabled if they are +* disabled. The 'watchdog_disabled' variable check in +* watchdog_*_all_cpus() function takes care of this. +*/ if (watchdog_enabled && watchdog_thresh)watchdog_enable_all_cpus ();else
Signature · 1 line
1.7.1
tip-bot for anish kumar
merge bot[tip:perf/core] watchdog: Add comments to explain the watchdog_disabled variable
watchdog: Add comments to explain the watchdog_disabled variable
Commit-ID: b66a2356d7108a15b8b5c9b8e6213e05ead22cd6 Gitweb: http://git.kernel.org/tip/b66a2356d7108a15b8b5c9b8e6213e05ead22cd6 Author: anish kumar <[email protected]> AuthorDate: Tue, 12 Mar 2013 14:44:08 -0400 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 14 Mar 2013 08:24:05 +0100
watchdog: Add comments to explain the watchdog_disabled variable
The watchdog_disabled flag is a bit cryptic. However it's usefulness is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in
sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.--- kernel/watchdog.c | 5 +++++ 1 file changed, 5 insertions(+)
kernel/watchdog.c +5 -0
@@ -517,6 +517,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,return ret;set_sample_period (); +/* +* Watchdog threads shouldn't be enabled if they are +* disabled. The 'watchdog_disabled' variable check in +* watchdog_*_all_cpus() function takes care of this. +*/ if (watchdog_enabled && watchdog_thresh)watchdog_enable_all_cpus ();else