Skip to contentSkip to conversation

CONFIG_EARLY_PRINTK

DISCUSSION Thomas Meyer 3 participants 7 messages Mar 13, 2013 – Mar 26, 2013 x86

lore
Share & tools
lore
#0 lore raw

Hi,

-*- Early printk

help text says:
"You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n])"

How to normally N here?

kind regards
thomas

#1 lore raw
Quoted 9 lines · Thomas Meyer

Hi,

-*- Early printk

help text says:
"You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n])"

How to normally N here?

You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.

You may even have to disable CONFIG_EMBEDDED before you can enable CONFIG_EXPERT (I did).

Too many hoops to have to jump through. :(

Signature · 1 line
~Randy
#2 lore raw

Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:

Quoted 9 lines · Thomas Meyer
Quoted 8 lines

Hi,

-*- Early printk

help text says:
"You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n])"

Quoted 9 lines
Quoted 1 line

How to normally N here?

You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.

You may even have to disable CONFIG_EMBEDDED before you can enable CONFIG_EXPERT (I did).

Too many hoops to have to jump through. :(

Yes,

so why not do this? As the text to EARLY_PRINTK explains?

arch/x86/Kconfig.debug +1 -1
index b322f12..d6c2d89 100644
@@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
 
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
+       default n
        ---help---
          Write kernel log output directly into the VGA buffer or to a

serial
port.

Acked-by
#3 lore raw
Quoted 17 lines · Thomas Meyer

Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:

Quoted 16 lines · Thomas Meyer
Quoted 9 lines

Hi,

-*- Early printk

help text says:
"You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n])"

How to normally N here?

You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.

You may even have to disable CONFIG_EMBEDDED before you can enable CONFIG_EXPERT (I did).

Quoted 6 lines
Quoted 2 lines

Too many hoops to have to jump through. :(

Yes,

so why not do this? As the text to EARLY_PRINTK explains?

Yes, the default should match the help text.

Please resend your patch with Signed-off-by: line.

Thanks.

Quoted 18 lines
arch/x86/Kconfig.debug +1 -1
index b322f12..d6c2d89 100644
@@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
 
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
+       default n
        ---help---
          Write kernel log output directly into the VGA buffer or to a

serial
port.

Signature · 1 line
~Randy
#4 lore raw
Quoted 7 lines · Randy Dunlap
Quoted 6 lines · Thomas Meyer

Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:

Quoted 5 lines · Thomas Meyer
Quoted 4 lines

help text says:
"You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n])"

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

How to normally N here?

so why not do this? As the text to EARLY_PRINTK explains?

Yes, the default should match the help text.

So just remove the "default n" line, as "n" is the default.

Quoted 13 lines

Please resend your patch with Signed-off-by: line.

Thanks.

Quoted 7 lines
arch/x86/Kconfig.debug +0 -0
index b322f12..d6c2d89 100644
@@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
 
Quoted 8 lines
Quoted 8 lines
arch/x86/Kconfig.debug +1 -1
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
+       default n
        ---help---
          Write kernel log output directly into the VGA buffer or to a

serial
port.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#5 lore raw
In reply to Randy Dunlap

Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:

Quoted 12 lines · Thomas Meyer
Quoted 4 lines

Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
Yes,

so why not do this? As the text to EARLY_PRINTK explains?

Yes, the default should match the help text.

Please resend your patch with Signed-off-by: line.

Thanks.

Align EARLY_PRINTK default value with help text value.

---

arch/x86/Kconfig.debug +0 -1
index b322f12..852d51c 100644
@@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
 
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
        ---help---
          Write kernel log output directly into the VGA buffer or to a serial
          port.
Acked-by
#6 lore raw
Quoted 10 lines · Thomas Meyer

Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:

Quoted 9 lines · Thomas Meyer
Quoted 4 lines

Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
Yes,

so why not do this? As the text to EARLY_PRINTK explains?

Yes, the default should match the help text.

Quoted 7 lines
Quoted 3 lines

Please resend your patch with Signed-off-by: line.

Thanks.

Align EARLY_PRINTK default value with help text value.

Thanks.

tip??

Quoted 17 lines

---

arch/x86/Kconfig.debug +0 -2
index b322f12..852d51c 100644
@@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
 
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
        ---help---
          Write kernel log output directly into the VGA buffer or to a serial
          port.
 
 
--
Signature · 1 line
~Randy