Skip to contentSkip to conversation

imx_drm: ipu_v3: fix invalid free of devm_* allocated data

PATCH In review Silviu-Mihai Popescu 2 participants 2 messages Mar 16, 2013 – Mar 19, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx_drm: ipu_v3: fix invalid free of devm_* allocated data

The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. There is no need to use kfree() explicitly.

---
 drivers/staging/imx-drm/ipu-v3/ipu-dp.c |    1 -
 1 file changed, 1 deletion(-)
drivers/staging/imx-drm/ipu-v3/ipu-dp.c +0 -1
index 26aecaf..113b046 100644
@@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, unsigned long base)
 
 	priv->base = devm_ioremap(dev, base, PAGE_SIZE);
 	if (!priv->base) {
-		kfree(priv);
 		return -ENOMEM;
 	}
 
Signature · 1 line
1.7.9.5
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Silviu-Mihai Popescu

The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. There is no need to use kfree() explicitly.

Not only 'no need', it's simply wrong.

Quoted 2 lines

Sascha

Quoted 20 lines
---
 drivers/staging/imx-drm/ipu-v3/ipu-dp.c |    1 -
 1 file changed, 1 deletion(-)
drivers/staging/imx-drm/ipu-v3/ipu-dp.c +0 -1
index 26aecaf..113b046 100644
@@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, unsigned long base)
 
 	priv->base = devm_ioremap(dev, base, PAGE_SIZE);
 	if (!priv->base) {
-		kfree(priv);
 		return -ENOMEM;
 	}
 
Signature · 1 line
1.7.9.5
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |