imx_drm: ipu_v3: fix invalid free of devm_* allocated data
Subsystems (2)
PATCH 1/1 imx_drm: ipu_v3: fix invalid free of devm_* allocated data
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. There is no need to use kfree() explicitly.
Signed-off-by Silviu-Mihai Popescu <[email protected]>
--- drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/imx-drm/ipu-v3/ipu-dp.c +0 -1
@@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, unsigned long base) priv->base =devm_ioremap (dev, base,PAGE_SIZE );if (!priv->base) { -kfree (priv);return -ENOMEM ; }
Signature · 1 line
1.7.9.5
Quoted 2 lines · Silviu-Mihai Popescu
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. There is no need to use
kfree()explicitly.
Not only 'no need', it's simply wrong.
Quoted 2 lines
Signed-off-by Silviu-Mihai Popescu <[email protected]>
Acked-by Sascha Hauer <[email protected]>
Sascha
Quoted 20 lines
--- drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/imx-drm/ipu-v3/ipu-dp.c +0
-1@@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, unsigned long base) priv->base =devm_ioremap (dev, base,PAGE_SIZE );if (!priv->base) { -kfree (priv);return -ENOMEM ; }Signature · 1 line
1.7.9.5
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |