Skip to contentSkip to conversation

request line field in the generic slave config structure

DISCUSSION Shevchenko, Andriy 3 participants 4 messages Mar 18, 2013 – Mar 21, 2013

lore
Share & tools
lore
#0 lore raw

Hello!

It seems the one (as I think good) question was left unanswered:
http://www.spinics.net/lists/arm-kernel/msg186120.html

What is your opinions, comments?

Signature · 13 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�
#1 lore raw
Quoted 6 lines · Andriy

Hello!

It seems the one (as I think good) question was left unanswered:
http://www.spinics.net/lists/arm-kernel/msg186120.html

What is your opinions, comments?

I'm not sure I understand what the question was. Is this about whether we should remove the "slave_id" field in the slave configuration?

Those sort of duplicate the request line information that comes from the platform in a data structure that should be filled by the device driver without platform specific knowledge.

I believe that is currently used by shmobile, and we won't be able to kill that before that platform has been converted to use dma_request_slave_channel.

Arnd

#3 lore raw
In reply to Shevchenko, Andriy
Quoted 6 lines · Andriy

Hello!

It seems the one (as I think good) question was left unanswered:
http://www.spinics.net/lists/arm-kernel/msg186120.html

What is your opinions, comments?

I'm not sure I understand what the question was. Is this about whether we should remove the "slave_id" field in the slave configuration?

Those sort of duplicate the request line information that comes from the platform in a data structure that should be filled by the device driver without platform specific knowledge.

I believe that is currently used by shmobile, and we won't be able to kill that before that platform has been converted to use dma_request_slave_channel.

Arnd

#2 lore raw
In reply to Arnd Bergmann
Quoted 11 lines · Arnd Bergmann
Quoted 6 lines · Andriy

Hello!

It seems the one (as I think good) question was left unanswered:
http://www.spinics.net/lists/arm-kernel/msg186120.html

What is your opinions, comments?

I'm not sure I understand what the question was. Is this about whether we should remove the "slave_id" field in the slave configuration?

Ditto :)

The slave_id memeber in dma_slave_config should be used for this

Quoted 10 lines

Those sort of duplicate the request line information that comes from the platform in a data structure that should be filled by the device driver without platform specific knowledge.

I believe that is currently used by shmobile, and we won't be able to kill that before that platform has been converted to use dma_request_slave_channel.

Arnd