Skip to contentSkip to conversation

Tests: Fix nprocesses applications shutdown

PATCH David Goulet 1 participant 1 message Mar 19, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

I have a problem with that. This gets printed for every application:

./test_nprocesses: line 80: 30283 Terminated
./$CURDIR/$TEST_BIN_NAME 1000 > /dev/null 2>&1

The output is not pretty :P

I'm having overall problem with this test for two reasons. First, with the new changes, registering an application takes a bit longer because of the back and forth notification event to register events and channels. This makes the "list application validation" fail most of the time. Increasing the sleep time helps but it is VERY ARBITRARY.

The second thing is that running this test with a normal user, too many open files is hit in the consumer and the test of course fails.

So, I think I'll have to find a clever way to validate applications so not to wait an arbitrary amount of time and probably drop the applications from 100 to 50.

David

Christian Babeux:

Quoted 36 lines

The nprocesses test is using the SIGPIPE signal to shutdown the spawned child applications. This is done in order to silence the shell message such as this one:

"nprocesses/test_nprocesses: line 79: 26458 Terminated"

This mechanism is broken on systems where the SIGPIPE default handler is overriden (thus no application shutdown occurs) in the executing environment. This could lead to stale applications polluting the system and causing heratic behavior in subsequent tests.

This commit add a loop and check that all the spawned applications have been successfully killed.

---
 tests/regression/ust/nprocesses/test_nprocesses | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
tests/regression/ust/nprocesses/test_nprocesses +4 -2
index e89d02e..23d9a0a 100755
@@ -74,8 +74,10 @@ destroy_lttng_session $SESSION_NAME
 
 rm -rf $TRACE_PATH
 
-# Send SIGPIPE to 'silence' bash process status such as "Process as terminated"
-killall -s PIPE -q $TEST_BIN_NAME >/dev/null 2>&1
+while [ -n "$(pidof $TEST_BIN_NAME)" ]; do
+	killall -q $TEST_BIN_NAME >/dev/null 2>&1
+	sleep 0.5
+done
 
 pass "Kill all spawned applications"